Red Hat Bugzilla – Bug 437917
Review Request: perl-Array-RefElem - Set up array elements as aliases
Last modified: 2008-03-18 16:06:39 EDT
SRPM URL: http://fedora.biggerontheinside.net/review/perl-Array-RefElem-1.00-1.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Array-RefElem.spec Description: This module gives direct access to some of the internal Perl routines that let you store things in arrays and hashes.
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=520459
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=520459 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 43ff2dd2049258634cb00697198572d1 Array-RefElem-1.00.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=5, 0 wallclock secs ( 0.00 cusr + 0.00 csys = 0.00 CPU) + Package perl-Array-RefElem-1.00-1.fc9 => Provides: RefElem.so perl(Array::RefElem) = 1.00 Requires: libc.so.6 libc.so.6(GLIBC_2.1.3) perl(DynaLoader) perl(Exporter) perl(strict) perl(vars) rtld(GNU_HASH) APPROVED.
New Package CVS Request ======================= Package Name: perl-Array-RefElem Short Description: Set up array elements as aliases Owners: cweyl Branches: F-7, F-8, devel InitialCC: perl-sig
cvs done.
Thanks for the review! :)