Red Hat Bugzilla – Bug 437919
Review Request: perl-Catalyst-Controller-BindLex - Stash your lexical goodness
Last modified: 2008-03-19 15:40:14 EDT
SRPM URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Controller-BindLex-0.03-1.fc8.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Controller-BindLex.spec
This plugin lets you put your lexicals on the stash and elsewhere
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=521597
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=521597
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=9, 0 wallclock secs ( 0.29 cusr + 0.02 csys = 0.31 CPU)
+ Package perl-Catalyst-Controller-BindLex-0.03-1.fc9 =>
Provides: perl(Catalyst::Controller::BindLex) = 0.03
Requires: perl(Array::RefElem) perl(Carp) perl(Devel::Caller)
perl(Devel::LexAlias) perl(NEXT) perl(PadWalker) perl(Scalar::Util)
perl(attributes) perl(base) perl(strict) perl(warnings)
New Package CVS Request
Package Name: perl-Catalyst-Controller-BindLex
Short Description: Stash your lexical goodness
Branches: F-7, F-8, devel
Imported and built in rawhide, but I'm getting an odd error when trying to build
for F-7: "FAILED: BuildError: package perl-Catalyst-Controller-BindLex not in
list for tag dist-fc7-updates-candidate"
Anyways -- that appears to have cleared up :)
Thanks for the review! :)