Spec URL: http://salimma.fedorapeople.org/for_review/music/rubberband.spec SRPM URL: http://salimma.fedorapeople.org/for_review/music/rubberband-1.0.1-1.fc9.src.rpm Description: Rubber Band is a library and utility program that permits you to change the tempo and pitch of an audio recording independently of one another. This package is needed to update Sonic Visualiser to 1.2 -- please review. Thanks!
- Package meets naming and packaging guidelines: YES - Spec file matches base package name.: YES - Spec has consistant macro usage. YES - Meets Packaging Guidelines. YES - License: GPLv2+ - License field in spec matches: YES - License file included in package: YES - Spec in American English: YES - Spec is legible.: YES - Sources match upstream md5sum: eb9524064ae48d6a3af0779590ff4ebc rubberband-1.0.1.tar.bz2 - Package needs ExcludeArch: NO - BuildRequires correct: YES (builds correctly in koji/mock, see under SHOULD items) - Spec handles locales/find_lang: N/A - Package is relocatable and has a reason to be.: N/A - Package has %defattr and permissions on files is good.: YES - Package has a correct %clean section. YES - Package has correct buildroot: YES %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Package is code or permissible content: YES - Doc subpackage needed/used.: NO - Packages %doc files don't affect runtime.: YES - Headers/static libs in -devel subpackage.: YES - Spec has needed ldconfig in post and postun: YES - .pc files in -devel subpackage/requires pkgconfig: YES - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} : YES - .la files are removed. N/A - Package is a GUI app and has a .desktop file: N/A - Package compiles and builds on at least one arch. YES (F-8, i386) - Package has no duplicate files in %files. YES - Package doesn't own any directories other packages own. YES - Package owns all the directories it creates. YES - rpmlint output. rpmlint rubberband-1.0.1*.rpm rubberband-devel*.rpm rubberband-devel.i386: W: no-documentation (the warning can be ignored) - final provides and requires are sane (glibc, rpmlib provides removed): rubberband-1.0.1-1.fc8.i386.rpm ladspa-rubberband.so librubberband.so.1 vamp-rubberband.so rubberband = 1.0.1-1.fc8 = /sbin/ldconfig /sbin/ldconfig libfftw3.so.3 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libsamplerate.so.0 libsamplerate.so.0(libsamplerate.so.0.0) libsndfile.so.1 libsndfile.so.1(libsndfile.so.1.0) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) libvamp-sdk.so.1.1.0 rtld(GNU_HASH) rubberband-devel-1.0.1-1.fc8.i386.rpm rubberband-devel = 1.0.1-1.fc8 = librubberband.so.1 pkgconfig rubberband = 1.0.1-1.fc8 SHOULD Items: - Should build in mock: YES, SRPM builds successfully on koji for f-9: http://koji.fedoraproject.org/koji/taskinfo?taskID=543841 - Should build on all supported archs: YES (see above) - Should function as described. YES: tested on F-8, stretches .wav files nicely - Should have sane scriptlets. YES - Should have subpackages require base package with fully versioned depend. YES - Should have dist tag YES - Should package latest version YES Issues: None. APPROVED
Thanks! New Package CVS Request ======================= Package Name: rubberband Short Description: Audio time-stretching and pitch-shifting library Owners: salimma Branches: EL-5 F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs done.
rubberband-1.0.1-1.fc8 has been submitted as an update for Fedora 8
rubberband-1.0.1-1.fc7 has been submitted as an update for Fedora 7
Hmm, Michel, something is wrong here, this bug is closedm and the bodhi added comments suggest rubberband is in updates, but it isn't both according to: https://admin.fedoraproject.org/updates/F8/FEDORA-2008-2954 And in the repo it is still in updates-testing. Can you fix this please (request a push to stable in bodhi). Thanks!
Ping Michel, can this please be pushed to stabel updates?
Ping again, Can this please be pushed to stable updates?
This is getting really annoying now, really how much work is it to login to http://admin.fedoraproject.org/updates and the click on push to stable? Pingidy Pingie dy pong?
rubberband-1.0.1-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
rubberband-1.0.1-1.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.