Spec URL: http://cwickert.fedorapeople.org/review/thunar-shares.spec SRPM URL: http://cwickert.fedorapeople.org/review/thunar-shares-0.10-1.fc9.src.rpm Description: A Thunar file manager extension to share files using Samba. The backend is based on nautilus-share.
I would be happy to review this, look for a full review in a bit.
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 64b23eec63c65f50b3a068f15d757067 thunar-shares-0.10.tar.bz2 64b23eec63c65f50b3a068f15d757067 thunar-shares-0.10.tar.bz2.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - .la files are removed. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: None. I see no issues, this package is APPROVED.
Thanks for the Review. I wonder if we should include more documentation like nautilus-share does, but IMO it's not necessary because the README is very clear about the setup New Package CVS Request ======================= Package Name: thunar-shares Short Description: Thunar file manager extension to share files using Samba Owners: cwickert Branches: F-7 F-8 InitialCC: kevin Cvsextras Commits: yes
cvs done.
thunar-shares-0.10-1.fc8 has been submitted as an update for Fedora 8
thunar-shares-0.10-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.