Bug 442437 - Review Request: edje - A graphical layout and animation library
Summary: Review Request: edje - A graphical layout and animation library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Patrice Dumas
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 442266 442353
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-04-14 19:45 UTC by Pavel Shevchuk
Modified: 2008-05-06 17:57 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-05-06 17:57:26 UTC
Type: ---
Embargoed:
pertusus: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Pavel Shevchuk 2008-04-14 19:45:47 UTC
Spec URL: http://rpm.scwlab.com/edje-goes-rawhide/edje.spec
SRPM URL: http://rpm.scwlab.com/edje-goes-rawhide/edje-0.5.0.042-1.fc9.src.rpm
RPMs for i386 and x86_64 built in mock: http://rpm.scwlab.com/edje-goes-rawhide/

Description: 
A graphical layout and animation library for animated resizable, compressed and
scalable themes.

RPMLint is silent on all RPMs i built.
License is a bit customized, but Tom "spot" Callawayin from fedora-legal-list 
said it's MIT ( https://www.redhat.com/archives/fedora-legal-list/2008-April/
msg00020.html )
I've been able to successfully use rpms built in mock on different machine to 
built software against this library.

Comment 1 Pavel Shevchuk 2008-05-04 00:34:06 UTC
* Sun May 04 2008 Pavel "Stalwart" Shevchuk <stlwrt> - 0.5.0.042-2
- Added missing dependencies for edje-devel
- Fixed timestamp of source tarball
- Preserve timestamps of installed files
- Added html docs


New spec: http://rpm.scwlab.com/edje-goes-rawhide/edje.spec
New SRPM: http://rpm.scwlab.com/fedora/e/9/edje-0.5.0.042-2.x86_64/
edje-0.5.0.042-2.fc9.src.rpm
Built RPMs: http://rpm.scwlab.com/fedora/e/9/

Comment 2 Patrice Dumas 2008-05-06 10:05:30 UTC
* rpmlint is silent
* pseudo MIT license included
* follow packaging guidelines
* match upstream:
fc95528409351acea7a48862331eaffd  edje-0.5.0.042.tar.bz2
* %files section right
* library correctly packaged

X missing pkgconfig Requires for devel.

Also I would suggest breaking the buildrequires at 80 columns.

APPROVED with the pkgconfig Requires for devel.


Comment 3 Pavel Shevchuk 2008-05-06 10:17:24 UTC
New Package CVS Request
=======================
Package Name: edje
Short Description: A graphical layout and animation library
Owners: stalwart
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes

Comment 4 Kevin Fenzi 2008-05-06 16:21:12 UTC
cvs done.

Comment 5 Pavel Shevchuk 2008-05-06 17:57:26 UTC
Koji finished building packages. Thanks to everyone!


Note You need to log in before you can comment on or make changes to this bug.