Bug 442910 - system-config-lvm desktop file incorrect
Summary: system-config-lvm desktop file incorrect
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-lvm
Version: 9
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Jim Parsons
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 446774 458546 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-04-17 15:19 UTC by Kevin Fenzi
Modified: 2009-07-05 14:56 UTC (History)
9 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-10-09 16:27:03 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Properly install the .desktop file (1.18 KB, patch)
2008-10-09 14:16 UTC, Deji Akingunola
no flags Details | Diff

Description Kevin Fenzi 2008-04-17 15:19:37 UTC
The system-config-lvm desktop file has: 
Categories=Application;SystemSetup;X-Red-Hat-Base;

See: 
http://standards.freedesktop.org/menu-spec/latest/apa.html

Both Application and SystemSetup are not valid. 

Perhaps it should be: 

System;Settings;X-Red-Hat-Base; ?

This issue makes system-config-lvm show up in the 'Other' menu item under Xfce.

Comment 1 Jim Parsons 2008-04-17 17:45:58 UTC
Yikes - Will respin today after i find out what the settings need to be.

Comment 2 Matthias Clasen 2008-04-17 17:58:17 UTC
If it is supposed to show up in the System > Administration menu (as I assume it
is), then System;Settings; is right. Nonbody cares about X-Red-Hat-Base anymore...

Comment 3 Deji Akingunola 2008-05-01 23:58:49 UTC
This bug is not fixed yet. It doesn't show up at all in a Gome-based fresh
installation. Matthias already responded on what the settings need to be.

Comment 4 David Timms 2008-05-05 14:00:32 UTC
Confirmed that for 2x machines upgraded from F8>F9beta>rawhide, that the LVM
configure icon does not show up anywhere in the gnome menus.

This diff shows that the desktop file install has been removed from the spec...
http://cvs.fedoraproject.org/viewcvs/rpms/system-config-lvm/F-9/system-config-lvm.spec?r1=1.27&r2=1.29

Is that because it is now inside the {unreachable} Source0: ?
Don't you still have to do either desktop-file-install {or verify} according to
the packaging guidelines ?

Comment 5 Bug Zapper 2008-05-14 09:35:05 UTC
Changing version to '9' as part of upcoming Fedora 9 GA.
More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 6 Deji Akingunola 2008-08-07 03:41:56 UTC
*** Bug 446774 has been marked as a duplicate of this bug. ***

Comment 7 john5342 2008-08-09 18:00:52 UTC
*** Bug 458546 has been marked as a duplicate of this bug. ***

Comment 8 Deji Akingunola 2008-10-09 14:16:09 UTC
Created attachment 319861 [details]
Properly install the .desktop file

The attached patch fix this issue, please apply.

Matthias, I noticed you have a commit right to this package, would you please apply it, just in case the owner is too busy to do it.

Comment 9 Matthias Clasen 2008-10-09 16:27:03 UTC
built in rawhide

Comment 10 Deji Akingunola 2008-10-10 04:07:59 UTC
Thanks Matthias. Unfortunately it failed to build, missing a BuildRequires on desktop-file-utils .

Comment 11 David Timms 2009-07-05 14:56:19 UTC
Confirmed fixed in:
- F10 (system-config-lvm-1.1.4-3.1.fc10.noarch)
- F11 (system-config-lvm-1.1.4-5.1.fc11.noarch). Both releases now show the LVM icon under System|Administration as expected.


Note You need to log in before you can comment on or make changes to this bug.