Spec URL: http://mmahut.fedorapeople.org/reviews/comedilib/comedilib.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/comedilib/comedilib.spec Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=578251 Description: Comedilib is a user-space library that provides a developer-friendly interface to Comedi devices. Included in the Comedilib distribution is documentation, configuration and calibration utilities, and demonstration programs.
SRPM URL: http://mmahut.fedorapeople.org/reviews/comedilib/comedilib-0.8.1-1.fc8.src.rpm (correcting, so that QA script is happy)
Thanks for the package, and sorry for the delay. Here's the review: 1.) Source file is not available for download. Probably the correct URL is: http://www.comedi.org/comedi/download/comedilib-0.8.1.tar.gz 2.) You should not use %makeinstall macro. See this document for reason: http://fedoraproject.org/wiki/Packaging/Guidelines#MakeInstall 3.) The build in mock failed for me. Seems like it did not generate python files, and failed to define %python_sitelib correctly. That might be because you omitted python-devel from BuildRequires.
Hi Lubomir, 1) Fixed. 2) Fixed. 3) It builds fine for me... http://koji.fedoraproject.org/koji/taskinfo?taskID=600026 http://koji.fedoraproject.org/koji/taskinfo?taskID=600033
Thanks for the fixes marek. I see no more issues with the package; APPROVED
thank you, New Package CVS Request ======================= Package Name: comedilib Short Description: Data Acquisition library for the Comedi driver Owners: mmahut Branches: EL-5, F-8, F-9 Cvsextras Commits: yes
cvs done.
thank you both, all done.