Red Hat Bugzilla – Bug 444223
Review Request: SAASound - Phillips SAA 1099 sound chip emulator library
Last modified: 2008-04-28 12:57:13 EDT
Spec URL: http://people.atrpms.net/~hdegoede/SAASound.spec
SRPM URL: http://people.atrpms.net/~hdegoede/SAASound-3.2-5.fc9.src.rpm
Phillips SAA 1099 sound chip emulator library.
OK source files match upstream:
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible (BSD). License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK shared libraries are added to the regular linker search paths, ldconfig call
N/A owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in -devel.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.
this package is APPROVED
Thanks for the review!
New Package CVS Request
Package Name: SAASound
Short Description: Phillips SAA 1099 sound chip emulator library
Branches: F-8 F-9
Cvsextras Commits: Yes
Imported and build, closing.