Red Hat Bugzilla – Bug 444225
Review Request: simcoupe - SAM Coupe emulator (spectrum compatible)
Last modified: 2008-04-28 12:57:07 EDT
Spec URL: http://people.atrpms.net/~hdegoede/simcoupe.spec
SRPM URL: http://people.atrpms.net/~hdegoede/simcoupe-1.0-4.fc9.src.rpm
SimCoupe emulates an 8bit Z80 based home computer, released in 1989 by Miles
Gordon Technology. The SAM Coupe was largely spectrum compatible, with much
Note this package Requires SAASound and samcoupe-rom, both of which are still under review, see bug 444223 and bug 444224.
OK source files match upstream:
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK is a GUI app, desktop file correctly installed
this package is APPROVED
New Package CVS Request
Package Name: simcoupe
Short Description: SAM Coupé emulator (spectrum compatible)
Branches: F-8 F-9
Cvsextras Commits: Yes
Imported and build, closing.