Bug 447965 - about:konqueror about:konqueror using kde3 styles
Summary: about:konqueror about:konqueror using kde3 styles
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: kdelibs
Version: 9
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Kevin Kofler
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-05-22 17:05 UTC by Rex Dieter
Modified: 2009-05-06 22:21 UTC (History)
6 users (show)

Fixed In Version: 4.0.80-2.fc10
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-05-06 19:18:12 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
KDE Software Compilation 157850 0 None None None Never

Description Rex Dieter 2008-05-22 17:05:42 UTC
from /usr/share/apps/kdeui (kdelibs3) instead of only the kde4 ones in
/usr/share/kde4/apps/kdeui.

kde4-config --path data
lists /usr/share/apps before /usr/share/kde4/apps which may have something to do
with it.

Comment 1 Rex Dieter 2008-05-23 14:28:15 UTC
well, in some quick-n-dirty testing, it appears kde3 and kde4 can share the 
*_datadir/kdeui, so that's what I'll try.  omit /usr/share/apps/kdeui from 
kdelibs3 and include a compat symlink in kdelibs-common.

doesn't solve the bigger kde4-config --path data problem, however.

excert from from #kde-devel: 
[08:36] <thiago> rdieter: KStandardDirs::addKDEDefaults
[08:36] <thiago> rdieter: it's a matter of swapping a few lines

doesn't seem that easy to me. :)

Comment 2 Mamoru TASAKA 2008-05-24 03:55:42 UTC
[root@localhost i386]# ls -al kdelibs*rpm
-rw-r--r-- 1 root root 13245752 May 23 06:45 kdelibs-4.0.72-5.fc10.i386.rpm
-rw-r--r-- 1 root root 13160041 May 24 00:05 kdelibs-4.0.72-7.fc10.i386.rpm
-rw-r--r-- 1 root root   178034 May 23 06:45 kdelibs-common-4.0.72-5.fc10.i386.rpm
-rw-r--r-- 1 root root   259814 May 24 00:04 kdelibs-common-4.0.72-7.fc10.i386.rpm
-rw-r--r-- 1 root root 12526668 May 16 11:50 kdelibs3-3.5.9-10.fc10.i386.rpm
-rw-r--r-- 1 root root 12447657 May 23 23:54 kdelibs3-3.5.9-12.fc10.i386.rpm
-rw-r--r-- 1 root root  2491772 May 16 11:49 kdelibs3-devel-3.5.9-10.fc10.i386.rpm
-rw-r--r-- 1 root root  2492031 May 23 23:54 kdelibs3-devel-3.5.9-12.fc10.i386.rpm
[root@localhost i386]# rpm -q kdelibs kdelibs3
kdelibs-4.0.72-5.fc10.i386
kdelibs3-3.5.9-10.fc10.i386
[root@localhost i386]# rpm -qf /usr/share/apps/kdeui
kdelibs3-3.5.9-10.fc10.i386
[root@localhost i386]# rpm -Fvh kdelibs*rpm
Preparing...                ########################################### [100%]
   1:kdelibs-common         ########################################### [ 25%]
error: unpacking of archive failed on file /usr/share/apps/kdeui: cpio: rename
failed - Is a directory
   2:kdelibs3               ########################################### [ 50%]
   3:kdelibs                ########################################### [ 75%]
   4:kdelibs3-devel         ########################################### [100%]

Comment 3 Kevin Kofler 2008-05-24 03:58:33 UTC
Argh, not again!
Rex, you CANNOT change a directory to a symlink! RPM doesn't support it.

Comment 4 Kevin Kofler 2008-05-24 04:04:03 UTC
I untagged the offending builds from dist-f10. (Kinda surprised that Koji let 
me do that given that those weren't my builds, but whatever.)

Comment 5 Kevin Kofler 2008-05-29 22:17:05 UTC
Rex cleaned up the hack meanwhile so it builds.

But there's now a non-hack fix (i.e. a fix for the underlying problem with the 
search path) here (thanks to Sune Vuorela (pusling) from Debian):
http://lists.kde.org/?l=kde-core-devel&m=121209523714815&w=2

That fix would also fix bug 446575 so in theory we could reintroduce those 
KCMs.

Comment 6 Than Ngo 2008-05-30 08:57:49 UTC
Rex, could you please revert the hack? the above fix looks good to me, we can 
add it in our package

Comment 7 Kevin Kofler 2008-05-30 09:05:40 UTC
Than, careful, I discussed some details with pusling on IRC, notably the 
priorities will be wrong for the config files. I'll come up with a patch which 
does the right thing for config files too ASAP.

Comment 8 Rex Dieter 2008-05-30 15:45:19 UTC
Re: comment #6
There is merit to leaving it as-is:
1 .kde3 and kde4 apps now share kdeui (as intended), so about->kde dialogs look
consistent
2. it's saves ~300k

Comment 9 Kevin Kofler 2008-05-30 16:12:07 UTC
Patches here:
4.0: http://repo.calcforge.org/f9/kdelibs-4.0.4-kstandarddirs.patch
4.1: http://repo.calcforge.org/f9/kdelibs-4.0.80-kstandarddirs.patch

These replace the existing kdelibs-4.0.4-kstandarddirs.patch, I added 
the /etc/kde hack to this patch. The difference between the combination of the 
existing patch and pusling's and the above version is that I fixed the search 
order for config files so /etc/kde and the kde-settings profile come first (so 
the desired preference order: sysadmin customizations before Fedora defaults 
before upstream defaults is maintained).

Comment 10 Than Ngo 2008-05-30 16:52:28 UTC
Kevin, the patch looks good, i will summit the fix into CVS and build it

Comment 11 Rex Dieter 2008-05-30 19:16:20 UTC
Testing kdelibs-4.0.4-11.fc9
$ kde4-config --path data
~/.kde/share/apps:/usr/share/kde4/apps:/usr/share/kde-settings/kde-profile/default/share/apps:/usr/share/apps

Not sure if that's exactly what we want, but maybe it's good enough.

Comment 12 Kevin Kofler 2008-05-30 19:29:54 UTC
You want /usr/share/kde-settings/kde-profile/default/share/apps to come first? 
That'll be a bit hard to implement, I'm afraid. :-(

Config is special-cased so you get the right thing (kde-profile first), but if 
I did the same thing for apps which I do for config, /usr/share/kde4/apps would 
be last and we'd lose again.

Comment 13 Rex Dieter 2008-05-30 20:11:04 UTC
We don't currently put anything there anyway, so it's no big deal.

Comment 14 Rex Dieter 2009-05-06 19:18:12 UTC
I think we've got this one nailed

Comment 15 Kevin Kofler 2009-05-06 22:13:12 UTC
Yes, that has been fixed for ages. The search path is now:
~/.kde/share/apps/:/usr/share/kde-settings/kde-profile/default/share/apps/:/usr/share/kde4/apps/
The KDE 3 /usr/share/apps/ is not searched by KDE 4 anymore at all.

Comment 16 Kevin Kofler 2009-05-06 22:21:00 UTC
For the record, this was fixed in kdelibs-4.0.80-2.fc10, all the 4.1 and 4.2 updates for F9 have this fixed, as does the F10 release.


Note You need to log in before you can comment on or make changes to this bug.