Bug 449328 - Review Request: cluttermm - C++ wrapper for clutter library
Summary: Review Request: cluttermm - C++ wrapper for clutter library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Brian Pepple
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-06-02 08:17 UTC by Denis Leroy
Modified: 2008-06-06 06:36 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-06-06 06:36:13 UTC
Type: ---
Embargoed:
bdpepple: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Denis Leroy 2008-06-02 08:17:07 UTC
Spec URL: http://www.poolshark.org/src/cluttermm.spec
SRPM URL: http://www.poolshark.org/src/cluttermm-0.5.1-1.fc9.src.rpm

Description:
Cluttermm is a C++ wrapper library for clutter: an OpenGL-based
library for creating fast, visually rich and animated graphical user
interfaces.

Comment 1 Denis Leroy 2008-06-02 08:24:15 UTC
Patch filed upstream at

http://bugzilla.gnome.org/show_bug.cgi?id=536181


Comment 2 Ralf Corsepius 2008-06-03 06:00:30 UTC
package doesn't build in mock:
...
checking for CLUTTERMM...
configure: error: Package requirements (gtkmm-2.4 >= 2.10.9
                  clutter-0.6) were not met:
No package 'gtkmm-2.4' found
...


Comment 3 Denis Leroy 2008-06-03 06:13:33 UTC
Well that was embarassing. Here's the fix.

Spec URL: http://www.poolshark.org/src/cluttermm.spec
SRPM URL: http://www.poolshark.org/src/cluttermm-0.5.1-2.fc9.src.rpm


Comment 4 Brian Pepple 2008-06-03 23:03:37 UTC
(In reply to comment #3)
> Well that was embarassing. Here's the fix.

Hate to say it, but it still fails to build.  Looks like a file your trying to
package as documentation doesn't exist.  Here's a link to a scratch build log:
http://koji.fedoraproject.org/koji/getfile?taskID=644003&name=build.log




Comment 5 Mamoru TASAKA 2008-06-04 02:41:57 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Well that was embarassing. Here's the fix.
> 
> Hate to say it, but it still fails to build.  Looks like a file your trying to
> package as documentation doesn't exist.  Here's a link to a scratch build log:
> http://koji.fedoraproject.org/koji/getfile?taskID=644003&name=build.log


This seems "touch" problem we are discussing on fedora-devel-list
starting on:
https://www.redhat.com/archives/fedora-devel-list/2008-June/msg00153.html


Comment 6 Denis Leroy 2008-06-04 09:17:38 UTC
Right, no koji builds until this is fixed.

For the record, it builds for me on F-9 i386, F-9 x86_64 and F10 i386.


Comment 7 Mamoru TASAKA 2008-06-04 16:45:38 UTC
By the way coreutils-6.12-1.fc10 is now untagged and I guess
now koji build succeeds.

Comment 8 Brian Pepple 2008-06-05 01:43:44 UTC
MD5Sum:
74ea582eccf312885bd190758018b5a2  cluttermm-0.5.1.tar.bz2

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Valid license tag
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners
* Rpmlint produces the following warnings that can be ignored:
  cluttermm-cairo.i386: W: no-documentation
  cluttermm-gtk.i386: W: no-documentation
* Package installs and uninstalls cleanly

Bad:
* Looking at the pkg-config files for some of your devel subpackages, it looks
like your missing a couple of requires.  The cluttermm-cairo-devel package looks
like it's missing a requires on cairomm-devel. The cluttermm-gtk-devel package
looks like it's missing a requires on gtkmm24-devel.  Please verify this before
importing it into CVS.

+1 APPROVE


Comment 9 Denis Leroy 2008-06-05 04:17:37 UTC
Yes, you're correct on the missing requires.

New Package CVS Request
=======================
Package Name: cluttermm
Short Description: C++ wrapper for clutter library
Owners: denis
Branches: F-8 F-9
Cvsextras Commits: yes


Comment 10 Kevin Fenzi 2008-06-05 16:19:28 UTC
cvs done.

Comment 11 Denis Leroy 2008-06-06 06:36:13 UTC
Brian, thanks for the quick review again.



Note You need to log in before you can comment on or make changes to this bug.