Bug 450482 - Review Request: libibumad - OpenFabrics Alliance InfiniBand umad (user MAD) library
Summary: Review Request: libibumad - OpenFabrics Alliance InfiniBand umad (user MAD) l...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: noarch
OS: Linux
low
low
Target Milestone: ---
Assignee: Ed Hill
QA Contact: Fedora Extras Quality Assurance
URL: http://people.redhat.com/dledford/Inf...
Whiteboard:
Depends On: 450481
Blocks: 450483
TreeView+ depends on / blocked
 
Reported: 2008-06-09 01:10 UTC by Doug Ledford
Modified: 2012-10-01 03:43 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-01-03 20:59:40 UTC
Type: ---
Embargoed:
ed: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Doug Ledford 2008-06-09 01:10:01 UTC
+++ This bug was initially created as a clone of Bug #450481 +++

+++ This bug was initially created as a clone of Bug #450470 +++

This package is a pre-cursor, helper package to opensm, the InfiniBand subnet
manager.  It relies upon the libibcommon package this bug was cloned from.

src rpm can be found under

http://people.redhat.com/dledford/Infiniband/f10/SRPMS/

x86_64 rpms can be found under

http://people.redhat.com/dledford/Infiniband/f10/x86_64/

Comment 1 Ed Hill 2008-06-28 17:51:27 UTC
Here's a review:

GOOD:
+ source matches upstream SHA1SUM:
    f50dcb3f1bc789dd2b951aae176b58774c6aeb44  libibumad-1.2.0.tar.gz
    f50dcb3f1bc789dd2b951aae176b58774c6aeb44  libibumad-1.2.0.tar.gz.UP
+ license ("GPLv2 or BSD") is correct and correctly included
+ proper use of ldconfig
+ *.la is correctly removed
+ builds locally (F8 x86_64)  w/ the libibcommon-devel installed
+ rpmlint reports two ignore-able warnings:
    libibumad-devel.x86_64: W: no-documentation
    libibumad-static.x86_64: W: no-documentation
+ dir ownership looks good
+ permissions look good

NEEDSWORK:
- The %install sections is missing a:
    rm -rf %{buildroot}
  at the beginning
- Please remove the ExclusiveArch:


Comment 2 Doug Ledford 2008-06-29 02:15:37 UTC
%install fixed and exclusivearch removed

Comment 3 Ed Hill 2008-06-29 13:31:18 UTC
APPROVED.

Comment 4 Doug Ledford 2008-06-30 13:20:44 UTC
New Package CVS Request
=======================
Package Name: libibumad
Short Description: OpenFabrics Alliance InfiniBand umad (user MAD) library
Owners: dledford
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes


Comment 5 Kevin Fenzi 2008-06-30 16:17:37 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.