Bug 450770 - ext3: potential data corruption on log replay
Summary: ext3: potential data corruption on log replay
Keywords:
Status: CLOSED DUPLICATE of bug 447742
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.2
Hardware: All
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Eric Sandeen
QA Contact: Martin Jenner
URL:
Whiteboard:
Depends On:
Blocks: 450772
TreeView+ depends on / blocked
 
Reported: 2008-06-10 21:05 UTC by Eric Sandeen
Modified: 2008-06-12 14:29 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-06-12 14:29:45 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Eric Sandeen 2008-06-10 21:05:02 UTC
This is very rare but also obvious enough I think it's worth fixing up.

From: Duane Griffin <duaneg>
Date: Thu, 20 Mar 2008 00:00:53 +0000 (-0700)
Subject: jbd: correctly unescape journal data blocks
X-Git-Tag: v2.6.25-rc7~82
X-Git-Url:
http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git;a=commitdiff_plain;h=439aeec639d7c57f3561054a6d315c40fd24bb74

jbd: correctly unescape journal data blocks

Fix a long-standing typo (predating git) that will cause data corruption if a
journal data block needs unescaping.  At the moment the wrong buffer head's
data is being unescaped.

To test this case mount a filesystem with data=journal, start creating and
deleting a bunch of files containing only JFS_MAGIC_NUMBER (0xc03b3998), then
pull the plug on the device.  Without this patch the files will contain zeros
instead of the correct data after recovery.

Signed-off-by: Duane Griffin <duaneg>
Acked-by: Jan Kara <jack>
Cc: <linux-ext4.org>
Cc: <stable>
Signed-off-by: Andrew Morton <akpm>
Signed-off-by: Linus Torvalds <torvalds>

Comment 1 RHEL Program Management 2008-06-10 21:10:02 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 3 Eric Sandeen 2008-06-12 14:29:45 UTC
oops, Josef already sent this!

*** This bug has been marked as a duplicate of 447742 ***


Note You need to log in before you can comment on or make changes to this bug.