Bug 450772 - ext3: potential data corruption on log replay
Summary: ext3: potential data corruption on log replay
Status: CLOSED DUPLICATE of bug 447741
Alias: None
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: kernel
Version: 4.8
Hardware: All
OS: Linux
Target Milestone: rc
: ---
Assignee: Eric Sandeen
QA Contact: Martin Jenner
Depends On: 450770
TreeView+ depends on / blocked
Reported: 2008-06-10 21:06 UTC by Eric Sandeen
Modified: 2008-06-12 14:28 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2008-06-12 14:28:43 UTC
Target Upstream Version:

Attachments (Terms of Use)

Description Eric Sandeen 2008-06-10 21:06:36 UTC
+++ This bug was initially created as a clone of Bug #450770 +++

This is very rare but also obvious enough I think it's worth fixing up.

From: Duane Griffin <duaneg@dghda.com>
Date: Thu, 20 Mar 2008 00:00:53 +0000 (-0700)
Subject: jbd: correctly unescape journal data blocks
X-Git-Tag: v2.6.25-rc7~82

jbd: correctly unescape journal data blocks

Fix a long-standing typo (predating git) that will cause data corruption if a
journal data block needs unescaping.  At the moment the wrong buffer head's
data is being unescaped.

To test this case mount a filesystem with data=journal, start creating and
deleting a bunch of files containing only JFS_MAGIC_NUMBER (0xc03b3998), then
pull the plug on the device.  Without this patch the files will contain zeros
instead of the correct data after recovery.

Signed-off-by: Duane Griffin <duaneg@dghda.com>
Acked-by: Jan Kara <jack@suse.cz>
Cc: <linux-ext4@vger.kernel.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Comment 1 RHEL Program Management 2008-06-10 21:09:58 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update

Comment 2 Eric Sandeen 2008-06-12 14:28:43 UTC
Oops, Josef did this already.

*** This bug has been marked as a duplicate of 447741 ***

Note You need to log in before you can comment on or make changes to this bug.