Red Hat Bugzilla – Bug 452470
Review-Request: perl-Test-WWW-Selenium - Perl Client for the Selenium Remote Control test tool
Last modified: 2008-07-01 14:01:01 EDT
SPEC: http://netbsd.sk/~lkundrak/SPECS/perl-Test-WWW-Selenium.spec SRPM: http://netbsd.sk/~lkundrak/mock-results/perl-Test-WWW-Selenium-1.15-1.el5.noarch/perl-Test-WWW-Selenium-1.15-1.el5.src.rpm mock: http://netbsd.sk/~lkundrak/mock-results/perl-Test-WWW-Selenium-1.15-1.el5.noarch/ Description: Selenium Remote Control (SRC) is a test tool that allows you to write automated web application UI tests in any programming language against any HTTP website using any mainstream JavaScript-enabled browser. SRC provides a Selenium Server, which can automatically start/stop/control any supported browser. It works by using Selenium Core, a pure-HTML+JS library that performs automated tasks in JavaScript; the Selenium Server communicates directly with the browser using AJAX (XmlHttpRequest).
Add Apache to License tag also. Build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=676057 Found missing perl(Test::Mock::LWP)
Apache License Added. As you correctly found out Tess::Mock::LWP is pending adding to Fedora. Thanks for adding the dependency! SPEC: http://netbsd.sk/~lkundrak/SPECS/perl-Test-WWW-Selenium.spec SRPM: http://netbsd.sk/~lkundrak/mock-results/perl-Test-WWW-Selenium-1.15-1.el5.noarch/perl-Test-WWW-Selenium-1.15-2.el5.src.rpm
The reason I have not done review of this is that I am repeatedly getting 404 error for SRPM download still.
Parag: I'm sorry for that. The correct URL is: http://netbsd.sk/~lkundrak/mock-results/perl-Test-WWW-Selenium-1.15-2.el5.noarch/perl-Test-WWW-Selenium-1.15-2.el5.src.rpm Thanks!
Review: + package builds in mock. koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=686732 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 932a71581ebfaad8bc544aa1eae39c5e Test-WWW-Selenium-0.15.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test All tests successful, 1 test skipped. Files=8, Tests=239, 1 wallclock secs ( 1.14 cusr + 0.04 csys = 1.18 CPU) APPROVED.
New Package CVS Request ======================= Package Name: perl-Test-WWW-Selenium Short Description: Perl Client for the Selenium Remote Control test tool Owners: lkundrak Branches: F-8 F-9 EL-5 Cvsextras Commits: yes
cvs done.
Imported and built. Thanks!