Bug 452471 - Review-Request: perl-Test-Mock-LWP - Easy mocking of LWP packages
Review-Request: perl-Test-Mock-LWP - Easy mocking of LWP packages
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
low Severity low
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
http://netbsd.sk/~lkundrak/SPECS/perl...
:
Depends On:
Blocks: 452470
  Show dependency treegraph
 
Reported: 2008-06-23 03:57 EDT by Lubomir Rintel
Modified: 2008-06-23 15:04 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-06-23 15:04:04 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Lubomir Rintel 2008-06-23 03:57:39 EDT
SPEC: http://netbsd.sk/~lkundrak/SPECS/perl-Test-Mock-LWP.spec
SRPM:
http://netbsd.sk/~lkundrak/mock-results/perl-Test-Mock-LWP-0.05-1.el5.noarch/perl-Test-Mock-LWP-0.05-1.el5.src.rpm
mock: http://netbsd.sk/~lkundrak/mock-results/perl-Test-Mock-LWP-0.05-1.el5.noarch/

Description:

This package arises from duplicating the same code to mock LWP et al in
several different modules I've written. This version is very minimalist,
but works for my needs so far. I'm very open to new suggestions and
improvements.

(TODO: Now I see this description sucks. I'll replace it when updating the package.)
Comment 1 Parag AN(पराग) 2008-06-23 04:17:32 EDT
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=676059
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
2496324cd4474966269847836770b7a0  Test-Mock-LWP-0.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test is ok.
All tests successful.
Files=2, Tests=11,  0 wallclock secs ( 0.07 cusr +  0.01 csys =  0.08 CPU)
+ Package perl-Test-Mock-LWP-0.05-1.fc10 =>
  Provides: perl(HTTP::Request) perl(HTTP::Response) perl(LWP::UserAgent)
perl(Test::Mock::HTTP::Request) = 0.01 perl(Test::Mock::HTTP::Response) = 0.01
perl(Test::Mock::LWP) = 0.05 perl(Test::Mock::LWP::UserAgent) = 0.01

Requires: perl(:MODULE_COMPAT_5.10.0) perl(Test::Mock::HTTP::Request)
 perl(Test::Mock::HTTP::Response) perl(Test::MockObject) perl(base) perl(strict)
perl(warnings)

APPROVED.
Comment 2 Lubomir Rintel 2008-06-23 04:25:57 EDT
Thanks Parag!

New Package CVS Request
=======================
Package Name: perl-Test-Mock-LWP
Short Description: Easy mocking of LWP packages
Owners: lkundrak
Branches: F-8 F-9 EL-5
Cvsextras Commits: yes
Comment 3 Kevin Fenzi 2008-06-23 11:44:14 EDT
cvs done.
Comment 4 Lubomir Rintel 2008-06-23 15:04:04 EDT
Thanks Parag, thanks Kevin.
Imported and built.

Note You need to log in before you can comment on or make changes to this bug.