Bug 452516 - Review Request: perl-AnyEvent - Framework for multiple event loops
Review Request: perl-AnyEvent - Framework for multiple event loops
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Extras Quality Assurance
:
Depends On:
Blocks: perl-Coro 452523
  Show dependency treegraph
 
Reported: 2008-06-23 10:22 EDT by Nicolas Chauvet (kwizart)
Modified: 2008-07-04 18:01 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-07-04 18:01:38 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Nicolas Chauvet (kwizart) 2008-06-23 10:22:40 EDT
Spec URL:
http://kwizart.fedorapeople.org/SPECS/perl-AnyEvent.spec
SRPM URL:
http://kwizart.fedorapeople.org/SRPMS/perl-AnyEvent-4.152-1.fc8.kwizart.src.rpm
Description: Framework for multiple event loops

http://koji.fedoraproject.org/koji/taskinfo?taskID=676522

This package filter the perl-Qt event module as it will need some special care, but is unmaintained until now.
Comment 1 Nicolas Chauvet (kwizart) 2008-06-23 10:55:57 EDT
I forgot to say that perl-EV needs to be filtered until it is built:
So here is the scratch build according to the above spec file:
http://koji.fedoraproject.org/koji/taskinfo?taskID=676543
Comment 2 Jason Tibbitts 2008-07-02 15:47:20 EDT
Not much to say here; this looks fine.

* source files match upstream:
   ce4f22202f705dee0e4303b85b1aa6475afadc3f50d0586b50a3966ea8633cb5  
   AnyEvent-4.152.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(AnyEvent) = 4.152
   perl(AnyEvent::Base)
   perl(AnyEvent::CondVar)
   perl(AnyEvent::CondVar::Base)
   perl(AnyEvent::DNS) = 4.151
   perl(AnyEvent::Handle) = 4.151
   perl(AnyEvent::Impl::EV)
   perl(AnyEvent::Impl::Event)
   perl(AnyEvent::Impl::EventLib)
   perl(AnyEvent::Impl::Glib)
   perl(AnyEvent::Impl::POE)
   perl(AnyEvent::Impl::Perl) = 4.151
   perl(AnyEvent::Impl::Tk)
   perl(AnyEvent::Socket) = 4.151
   perl(AnyEvent::Util) = 4.151
   perl-AnyEvent = 4.152-1.fc10
  =
   perl(:MODULE_COMPAT_5.10.0)
   perl(AnyEvent)
   perl(AnyEvent::DNS)
   perl(AnyEvent::Handle)
   perl(AnyEvent::Socket)
   perl(AnyEvent::Util)
   perl(Carp)
   perl(Errno)
   perl(Event)
   perl(Event::Lib)
   perl(Fcntl)
   perl(Glib)
   perl(POE)
   perl(Scalar::Util)
   perl(Socket)
   perl(Time::HiRes)
   perl(Tk)
   perl(base)
   perl(strict)

* %check is present and all tests pass:
   All tests successful, 1 test skipped.
   Files=10, Tests=74,  1 wallclock secs ( 0.35 cusr +  0.07 csys =  0.42 CPU)
   (the skipped test requires the network)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED
Comment 3 Nicolas Chauvet (kwizart) 2008-07-02 16:29:05 EDT
New Package CVS Request
=======================
Package Name: perl-AnyEvent
Short Description: Framework for multiple event loops
Owners: kwizart
Branches: F-8 F-9 EL-4 EL-5
InitialCC: perl-sig
Cvsextras Commits: yes
Comment 4 Kevin Fenzi 2008-07-04 16:16:01 EDT
cvs done.

Note You need to log in before you can comment on or make changes to this bug.