Spec URL: http://pfj.fedorapeople.org/monotorrent.spec SRPM URL: http://pfj.fedorapeople.org/monotorrent-0.4-1.fc10.src.rpm Description: monotorrent is a bittorrent client for mono.
Informal package review: ======================== -Group: Development/Languages -License: X11/MIT +Group: Applications/Internet +License: MIT * Found group which fits better. * https://fedoraproject.org/wiki/Licensing claims X11 to be MIT * NOTE: In sources is MIT but in COPYRIGHT file is GNU GPLv2. From my POV: It'd be good to contact author and ask him to be clear on this. # Bug 241850 - no Mono on pp64 -ExclusiveArch: %ix86 x86_64 ppc ia64 armv4l sparc alpha +ExcludeArch: ppc64 * I guess this is saner. %description -Monotorrent is a bittorrent for mono +Monotorrent is an open source bittorrent library. The main aim of this +library is to provide a rich API for developers to connect to so they +can harness BitTorrent for all downloading needs. * Some more descriptions. %package devel -Summary: .pc file for monotorrent +Summary: Development files for for monotorrent Group: Documentation Requires: %{name} = %{version}-%{release} pkgconfig %description devel -Package config file for monotorrent +Development files for for monotorrent * Just a strings. %prep %setup -q @@ -47,6 +49,7 @@ make DESTDIR=%{buildroot} install %{_libdir}/monotorrent/* %files devel +%defattr(-,root,root,-) %{_libdir}/pkgconfig/monotorrent.pc * This is necessary to have rpmlint silent. -- [root@dhcp-lab-192 SPECS]# rpmlint monotorrent.spec /usr/src/redhat/SRPMS/monotorrent-0.4-1.fc9.src.rpm /usr/src/redhat/RPMS/i386/monotorrent-0.4-1.fc9.i386.rpm /usr/src/redhat/RPMS/i386/monotorrent-devel-0.4-1.fc9.i386.rpm monotorrent.i386: E: no-binary monotorrent.i386: E: only-non-binary-in-usr-lib monotorrent-devel.i386: W: no-documentation 3 packages and 1 specfiles checked; 2 errors, 1 warnings. * Take a look at this. Complaint of the /usr/bin/... stuff not to be binaries (they are shell scripts). * Dunno about the /usr/lib/ stuff. Hope someone experienced will see this BZ. -- Please incorporate changes. Feel free to ask.
I'm back from vacation in Brazil now, so I will take this one. Review coming shortly, I promise.
Thank you Paul for packaging up this, any hope for Monsoon in Fedora? Since Michal already did fine work: %defattr(-,root,root,-) needed for the devel package and the descriptions and summaries need to be expanded a bit for clarity aside that this builds in mock (rawhide-x86_64) and otherwise stands up to the requirements. Clear up the license conflict as pointed out by Mr. Nowak. Michal: The exclusive line is a standard mono thing, we only have mono on certain platforms and currently ppc64 is unsupported so we note it by removing it from that exclusivearch line. It's not the clearest solution we know but it's intended this way. The rpmlint stuff is standard, rpmlint doesn't know all it needs to do to ignore this warning for mono packages - we tend to just ignore it rantings. I'll approve this, pending the license being worked out, Fedora makes no guanteees as to the license tag so we can ship with mistakes and the rest of the problems can be fixed up at import time. APPROVED
Paul: Can you add a cvs template here with what you want in your cvs request? See: http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure
New Package CVS Request ======================= Package Name: monotorrent Short Description: Bittorrent client for .NET Owners: pfj Branches: f8, f9, rawhide InitialCC: Cvsextras Commits: yes
cvs done.
You might want to close this BZ once is monotorrent live.
Paul do you plan to ever build this?
Okay spot built it on one of his license tag sprees