Bug 453870 - Review Request: iw - A nl80211 based wireless configuration tool
Review Request: iw - A nl80211 based wireless configuration tool
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Lubomir Rintel
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-02 19:16 EDT by Adel Gadllah
Modified: 2008-07-24 09:07 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-07-24 09:07:11 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
lkundrak: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Adel Gadllah 2008-07-02 19:16:03 EDT
Spec URL: http://tgmweb.at/gadllah/iw.spec
SRPM URL: http://tgmweb.at/gadllah/iw-0.0-0.1.20080703git.fc9.src.rpm
Description: 
iw is a new nl80211 based CLI configuration utility for wireless devices.
Currently you can only use this utility to configure devices which
use a mac80211 driver as these are the new drivers being written – 
only because most new wireless devices being sold are now SoftMAC.
Comment 1 Peter Lemenkov 2008-07-03 08:34:52 EDT
Remarks:

* You shpuld add comments describin how to create provided in Source0 tarball.
E.g.something like:

# svn export http://example.com/svn/name/trunk name-1.0.0
# tar cjvf name-1.0.0.tar.bz2 name-1.0.0
Source0:        name-1.0.0.tar.bz2

* You may simplify installation process. Instead of

mkdir -p $RPM_BUILD_ROOT%{_bindir}
install -m 0755 %{name} $RPM_BUILD_ROOT%{_bindir}/%{name}

you may do it in the following way:

install -D -p -m 0755 %{name} $RPM_BUILD_ROOT%{_bindir}/%{name}

Note -p (preserves timestamps) and -D (creates all necessary directories).
Comment 2 Adel Gadllah 2008-07-03 09:07:26 EDT
Thanks for the comments, fixed:
http://tgmweb.at/gadllah/iw.spec
http://tgmweb.at/gadllah/iw-0.0-0.2.20080703git.fc9.src.rpm
Comment 3 Lubomir Rintel 2008-07-22 06:14:45 EDT
Adel: Thanks for the package.

1.) I suggest you version the dependency on kernel-devel. At least headers from
el5's 2.6.18 are definitely not enough to build this.

2.) The comment that explains how to generate the source tarball should describe
how to reproduce the very same sourece tree, and I guess that I'll get a more
recent version if I did a simple git clone now. You should probably add a SHA
hash of the tree you are packaging, or whatever nonsense does GIT use instead of
revision numbers :)

Not really a blockers though -- there's nothing you can do wrong when doing that
at import time.

In all other respect, the package is perfect. Nice work. RPMlint is happy, SPEC
file is sane and legible, compiler flags are honoured. Therefore the package is

APPROVED
Comment 4 Adel Gadllah 2008-07-22 07:58:47 EDT
Thanks for the review, I have fixed 1) and 2) (fix will be in the imported package).

----------------------------

New Package CVS Request
=======================
Package Name: iw
Short Description: A nl80211 based wireless configuration tool
Owners: drago01
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes
Comment 5 Kevin Fenzi 2008-07-22 12:06:11 EDT
cvs done.

Note You need to log in before you can comment on or make changes to this bug.