Red Hat Bugzilla – Bug 454593
change hwcert code to work with bugzilla 3.2 after NEEDINFO status cleanup
Last modified: 2012-10-23 01:28:08 EDT
in the bugzilla 3.2 upgrade the NEEDINO status will be deleted and needinfo flag will be used for its purpose. as reported by hwcert team this has an affect on hwcert and so changes will need to be made to hwcert code accordingly to match the new change. the needinfo clean up script can be found in rh_bugzilla_3/redhat/needinfo_status_cleanup.pl which will have detailed design of the clean up process. but basically here is what we have done to delete the NEEDINFO status: 1- for all bugs with needinfo flag set to ? and the bug status is CLOSED we deleted the needinfo? flag from that bug. 2- for all bugs that are with open state not equal to NEEDINFO and has needinfo? flag set if there was a comment or attachment made after the needinfo? was set from the appropriate person then we delete the needinfo? flag from the bug. 3- all the bugs with current status set to NEEDINFO, if it has needinfo? flag set then just set the bug status to previous state it had before NEEDINFO 4- all the bugs with current status set to NEEDINFO, if it doesn't have the needinfo? flag set , then set the flag to needinfo? from anyone and set the bug status to previous state it had before NEEDINFO so basically to summarize: to know that a bug requires information ,, you just check for bugs with needinfo flag set to ? in bugzilla 3.2 and this replaces a bug having NEEDINFO status in bugzilla 2.18 I hope that above was clear, please do not hesitate to ask any questions. Noura
Rob, just wanted to touch base that the necessary information has been provided and you guys will be ready to go with this by August 2nd along with your other 3.2 related changes? Thanks Dave
Dave, I believe we have the information needed, this has been assigned and Eric is working on a patch. I'll talk with him tonight to find out when he plans on having the patch complete. We are still targeting the 7/26 date in hwcert to ensure we have the extra week as a window. -Rob
Created attachment 312231 [details] But to map the needinfo to NEEDINFO
Created attachment 312356 [details] patch to fix (1)-(5) entries in comment#5 patch to fix (1)-(5) entries in comment#5
Created attachment 312360 [details] a patch have been cleaned some useless thing out
Created attachment 312381 [details] newest first-part patch which fix the suggestion in comment#8 and comment#10 :)
I have already uploaded the newest first-part patch which fix the suggestion in comment#8 and comment#10 :)
edit.html: fine status_edit.html.tmpl @@ -2,26 +2,12 @@ The </hr> should remain, the status_edit template is currently correct, rh_edit (has an </hr> outside of an [% IF %]) and tam_ack (missing the starting </hr>) templates have errors which cause this. @@ -49,8 +35,9 @@ newstatus will need another default other than needinfo on the '<input type="hidden" name="newstatus" value="needinfo"' line General, because the drop down is removed we should change to using all caps for status so the 4 states are: Open: Leave as IN PROGRESS Change status to CLOSED/CERTIFIED Closed: Leave as CLOSED/CERTIFIED Re-Open certification as IN PROGRESS
Sir I have uploaded a new the patch which fixed above
Created attachment 312413 [details] fixed above comments
please review @ http://bugdev.devel.redhat.com/hwcert-eric2/show.cgi?id=456123
Looks good, I'm not certain the rh_edit @@ -4,7 +4,7 @@ change is really needed but otherwise please commit this change.
Created attachment 312693 [details] Updated needinfo as a flag patch Replaces previous efforts, uses the existing flags infrastructure from within a new template; also address a User.pm change where email_prefs was removed in the bz3 effort but is required by the flags module; also corrects for a missing use of the is_active field deprecated in bug #443465 disguised as "exists". Unfortunately the db is down for now so I can no longer verify function, so it'll probably still need some UI updates though @ last run before the test db's went down for maint. basic operation was correct, but the JS to auto select the radio's wasn't working. The patch has been cleaned up since them to simplify the interface and may no longer work, or work as expect but not as desired or some combination.
Created attachment 312921 [details] minor update to needinfo-flag patch Changes committed to CVS
testedd and run good