Spec URL: http://kwizart.fedorapeople.org/SPECS/iwl5000-firmware.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/iwl5000-firmware-5.4.A.11-1.src.rpm Description: Firmware for Intel® PRO/Wireless 5000 A/G/N network adaptors I don't know if the letter in version will be a problem. I just hope that they will update the two first numbers instead.
No errors or warnings from rpmlint, so on to the spec file... Pretty simple package, don't think the letter in the version matters. Only real issue I see is that you're putting the docs into /lib/firmware, while I believe the preferred location would be %docdir, and the license doesn't prevent us from putting it there -- iirc, ivtv-firmware has this requirement, but no such thing for Intel wireless firmware (just look at your own iwl4965-firmware package. :) Basically, just %doc the license and readme (or provide reasons why it must be in /lib/firmware), and I'll approve the package. Heck, I even have hardware to test with now, once driver support gets into rawhide, which kyle claims he's going to do today... :)
Spec URL: http://kwizart.fedorapeople.org/SPECS/iwl5000-firmware.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/iwl5000-firmware-5.4.A.11-2.src.rpm Description: Firmware for Intel® PRO/Wireless 5000 A/G/N network adaptors Changelog - Add LICENSE.iwlwifi-5000-ucode README.iwlwifi-5000-ucode as %%doc I think that previously, packaging License within /lib/firmware was required if packages are installed with --excludedocs , so the License could still be installed. But indeed, nothing "still" mention this from our packaging guideline. https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Binary_Firmware Usually nodist package are aimed to be built in the older release (F-8) and then inherited in lastest (Rawhide). Maybe there will be a problem if users expect support from iwl5000 from F-8 as soon as the related firmware is in the F-8 repository (F-8 last kernel doesn't seems to have iwl5000.ko). @Linville Do you think that such support can be provided within the F-8 kernel ? If not, I will built it since F-9
Ah, hrm, hadn't ever picked up on that requirement, I was going solely on my reading of the license and "prior art" -- your iwl4965-firmware package. :) As I understand it, there won't be an iwl5000 kernel module, the iwl4965 and iwl5000 chipsets will be driven by the same kernel module, which is going to be renamed to something else (with a modalias of iwl4965). No real reason it couldn't be backported to F8 if it can be brought back to F9, since the two kernels are quite similar... Though I'm not sure how many people with iwl5000 hardware would still be running F8, since the chip is newer than F9. Could be retro-fits or KDE3 holdouts, I guess... :) Need to put mine in sooner or later and see what I can see... Oh yeah: Package APPROVED.
New Package CVS Request ======================= Package Name: iwl5000-firmware Short Description: Firmware for Intel® PRO/Wireless 5000 A/G/N network adaptors Owners: kwizart Branches: F-8 F-9 EL-4 EL-5 Cvsextras Commits: yes
cvs done.
iwl5000-firmware-5.4.A.11-2 has been submitted as an update for Fedora 8
iwl5000-firmware-5.4.A.11-2 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update iwl5000-firmware'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-7122
And this package is going to be built for F9 and devel as well, right?
No. This package is a nodist and noarch package. The F-8 built will be inherited in the F-9 stable repository once it will hi the F-8 stable repository. Did you tried it ?
Nicolas, I don't think the process is automatic, you probably have to prod someone in rel-eng to manually inherit this up to F9 and devel. I had to do so for another firmware package just a few weeks ago.
*** Bug 459689 has been marked as a duplicate of this bug. ***
iwl5000-firmware-5.4.A.11-2 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.