Bug 456828 - Review Request: libasyncns - Asynchronous Name Service Library
Summary: Review Request: libasyncns - Asynchronous Name Service Library
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Dan Horák
QA Contact: Fedora Extras Quality Assurance
: 459896 (view as bug list)
Depends On:
TreeView+ depends on / blocked
Reported: 2008-07-27 21:53 UTC by Lennart Poettering
Modified: 2008-08-24 21:36 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2008-08-06 13:59:13 UTC
Type: ---
dan: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Lennart Poettering 2008-07-27 21:53:14 UTC
Spec URL: http://0pointer.de/public/libasyncns.spec
SRPM URL: http://0pointer.de/public/libasyncns-0.4-1.fc10.src.rpm

libasyncns is a C library for Linux/Unix for executing name service queries asynchronously. It is an asynchronous wrapper around getaddrinfo(3), getnameinfo(3), res_query(3) and res_search(3) from libc and libresolv.

In contrast to GNU's asynchronous name resolving API getaddrinfo_a(), libasyncns does not make use of UNIX signals for reporting completion of name queries. Instead, the API exports a standard UNIX file descriptor which may be integerated cleanly into custom main loops.

In contrast to asynchronous DNS resolving libraries like libdenise, skadns, adns, libasyncns is just an asynchronous wrapper around the libc's synchronous getaddrinfo() API, which has the advantage of allowing name resolution using techniques like Multicast DNS, LDAP or NIS using standard libc NSS (Name Service Switch) modules. libasyncns is compatible with IPv6 if the underlying libc is.

This has been a recommended (though optional) PulseAudio dependency for quite a while, but I never bothered to actually package this for Fedora. So here it finally is.

Comment 1 Dan Horák 2008-07-28 06:25:02 UTC
OK	source files match upstream:
	    047dd4c748c6061fa107c1877affc0a34c0847b3  libasyncns-0.4.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible (LGPLv2+). License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (Rawhide/x86_64).
OK	debuginfo package looks complete.
OK	rpmlint is silent.
OK	final provides and requires look sane.
N/A	%check is present and all tests pass.
OK	shared libraries are added to the regular linker search paths.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	correct scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	headers in devel.
OK	pkgconfig files in devel.
OK	no libtool .la droppings.
OK	not a GUI app.

this package is APPROVED

you could remove --disable-rpath when calling %configure as it is not understood
configure: WARNING: Unrecognized options: --disable-rpath

Comment 2 Lennart Poettering 2008-07-28 11:32:33 UTC
New Package CVS Request
Package Name: libasyncns
Short Description: Asynchronous Name Service Library
Owners: lennart
Cvsextras Commits: yes

Comment 3 Kevin Fenzi 2008-07-28 16:13:59 UTC
cvs done.

Comment 4 Dan Horák 2008-07-29 06:34:03 UTC
Lennart, you should close this "bug" after the package is imported and built.

Comment 5 Brian Pepple 2008-08-24 21:36:59 UTC
*** Bug 459896 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.