Bug 459896 - Review Request: libasyncns - Library for querying name services asynchronously
Review Request: libasyncns - Library for querying name services asynchronously
Status: CLOSED DUPLICATE of bug 456828
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: manuel wolfshant
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2008-08-23 18:38 EDT by Brian Pepple
Modified: 2008-08-24 17:36 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-08-24 17:36:59 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
wolfy: fedora‑review+
kevin: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Brian Pepple 2008-08-23 18:38:54 EDT
Spec URL: http://bpepple.fedorapeople.org/rpms/libasyncns.spec
SRPM URL: http://bpepple.fedorapeople.org/rpms/libasyncns-0.5-1.fc9.src.rpm
Description: libasyncns is a C library for Linux/Unix for executing name service queries asynchronously. It is an asynchronous wrapper around getaddrinfo(3),
getnameinfo(3), res_query(3) and res_search(3) from libc and libresolv.

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=781796
Comment 1 manuel wolfshant 2008-08-23 19:26:39 EDT
I got a stupid question? How can I test that these libs actually to what they are supposed to do ?
Comment 2 Brian Pepple 2008-08-23 19:44:49 EDT
There's not an easy way for you to test it.  I'm adding this to Fedora (Rawhide-only), so we can build telepathy-salut with libasyncns support.
Comment 3 manuel wolfshant 2008-08-23 19:50:40 EDT
Package Review

 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format %{name}.spec.
 [x] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one supported architecture.
     Tested on: devel/x86_64
 [x] Rpmlint output:
source RPM: empty
binary RPM:empty
 [x] Package is not relocatable.
 [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: LGPLv2+
 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided in the spec URL.
     SHA1SUM of package: 7d44d6476dbf9df17922fa744dc426fedc41c29e libasyncns-0.5.tar.gz
 [x] Package is not known to require ExcludeArch
 [-] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [x] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [x] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [x] Package requires pkgconfig, if .pc files are present.
 [x] Development .so files in -devel subpackage, if present.
 [x] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI application.
 [x] Package does not own files or directories owned by other packages.

 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: devel/x86_64 + koji scratch build
 [-] Package should compile and build into binary rpms on all supported architectures.
     Tested on: devel/ all archs  (koji scratch build)
 [?] Package functions as described.
 [x] Scriptlets must be sane, if used.
 [x] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.

=== Issues ===
 I suggest adding INSTALL="install -p" to the make line (I have tested locally - this will preserve the timestamp of the header file[s] included in the -devel package)

*** APPROVED ***

/me hoping for telepathy in EPEL ...
Comment 4 Brian Pepple 2008-08-23 20:34:49 EDT
New Package CVS Request
Package Name: libasyncns
Short Description: Library for querying name services asynchronously
Owners: bpepple
Comment 5 Kevin Fenzi 2008-08-24 14:49:54 EDT
cvs done.
Comment 6 Brian Pepple 2008-08-24 17:36:59 EDT
Closing as a duplicate, since my bugzilla skillz must suck. contacted nirik to correct the owner of this package.

*** This bug has been marked as a duplicate of bug 456828 ***

Note You need to log in before you can comment on or make changes to this bug.