Bug 457505 - Review Request: perl-Wx-Perl-ProcessStream
Summary: Review Request: perl-Wx-Perl-ProcessStream
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Robin Norwood
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-08-01 07:49 UTC by Marcela Mašláňová
Modified: 2008-08-12 14:40 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-08-12 14:40:17 UTC
Type: ---
robin.norwood: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Marcela Mašláňová 2008-08-01 07:49:51 UTC
This module provides the STDOUT, STDERR and exit codes of asynchronously
running processes via events. It may be used for long running or blocking
processes that provide periodic updates on state via STDOUT. Simple IPC is
possible via STDIN.

http://mmaslano.fedorapeople.org/perl-Wx-Perl-ProcessStream/perl-Wx-Perl-ProcessStream-0.11-1.fc9.src.rpm
http://mmaslano.fedorapeople.org/perl-Wx-Perl-ProcessStream/perl-Wx-Perl-ProcessStream.spec

Comment 1 Robin Norwood 2008-08-01 16:47:29 UTC
Review results - the starred items need to be fixed before I can pass the
package review:

- Source matches upstream
- rpmlint passes

* Missing BuildRequires: perl(Test::More)

* Error generating Makefile:
+ /usr/bin/perl Makefile.PL INSTALLDIRS=vendor
Checking if your kit is complete...
Looks good
Error: Unable to initialize gtk, is DISPLAY set properly?
Writing Makefile for Wx::Perl::ProcessStream

Is this a real error?  I suspect not, since the package still builds and works.


- Package naming is ok
- License is ok
- Source matches upstream

* Package does *not* build in koji.  See:
http://koji.fedoraproject.org/koji/taskinfo?taskID=753064

From build.log:

"""
Error: Unable to initialize gtk, is DISPLAY set properly?
Use of uninitialized value $Wx::_universal in concatenation (.) or string at
/usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Wx.pm line 176.
Use of uninitialized value $Wx::_static in concatenation (.) or string at
/usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Wx.pm line 177.
Use of uninitialized value $Wx::wxVERSION_STRING in concatenation (.) or string
at
/builddir/build/BUILD/Wx-Perl-ProcessStream-0.11/blib/lib/Wx/Perl/ProcessStream.pm
line 346.
"""

Probably the best solution is to include a patch to disable/comment out the
tests that fail.

FYI, you can do a koji scratch build easily.  Just build an SRPM with your
changes, and run:

$ koji build --skip-tag --scratch dist-f9 /path/to/SRPM

That way you can make sure you've gotten all the failing tests.

- File and directory ownership is ok



Comment 2 Marcela Mašláňová 2008-08-04 07:11:55 UTC
*** Bug 457286 has been marked as a duplicate of this bug. ***

Comment 4 Robin Norwood 2008-08-04 13:58:39 UTC
Everything looks good now - approved.

Comment 5 Marcela Mašláňová 2008-08-11 08:28:39 UTC
New Package CVS Request
=======================
Package Name: perl-Wx-Perl-ProcessStream
Short Description: proccess output via events
Owners: mmaslano
Branches: F-10
InitialCC: fedora-perl-devel-list@redhat.com

Comment 6 Kevin Fenzi 2008-08-11 17:36:48 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.