Spec URL: http://odysseus.x-tnd.be/fedora/php-pear-MDB2-Driver-pgsql/php-pear-MDB2-Driver-pgsql.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-pear-MDB2-Driver-pgsql/php-pear-MDB2-Driver-pgsql-1.4.1-1.fc9.src.rpm Mock Log: http://odysseus.x-tnd.be/fedora/php-pear-MDB2-Driver-pgsql/php-pear-MDB2-Driver-pgsql-build.log Description: This is the PostgreSQL MDB2 driver. rpmlint against srpm complains about a patch non apllied, I think it's just because the path is applied once installed (bug #379081). rpmlint against rpm also complains about missing documentation, there is no documentation provided upstream for this package.
*** Bug 438805 has been marked as a duplicate of this bug. ***
Indeed, rpmlint complains about the two things you've pointed out; I agree that both complaints can be ignored. The only thing I could suggest you add is some statement of why the file has to be patched after installation instead if in %prep as usual. (I understand why but it might not be obvious to whoever might glance at the spec in the future.) * source files match upstream: 7a051e90c63897701a93c9d3b02d79e6c696240c552694cf34cbc7eab6284691 MDB2_Driver_pgsql-1.4.1.tgz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream (it's in each of the PHP files). * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane: php-pear(MDB2_Driver_pgsql) = 1.4.1 php-pear-MDB2-Driver-pgsql = 1.4.1-1.fc10 = /bin/sh /usr/bin/pear php-pear(MDB2) >= 2.4.1 php-pear(PEAR) * %check is not present; there's a test suite, but it would require a running postgres instance and pear tests aren't runnable at build time in any case. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear module registration). * code, not content. * no documentation to worry about. APPROVED
New Package CVS Request ======================= Package Name: php-pear-MDB2-Driver-pgsql Short Description: PostgreSQL MDB2 Driver Owners: trasher Branches: F-8 F-9 EL-5 InitialCC: trasher Cvsextras Commits: yes
cvs done.
php-pear-MDB2-Driver-pgsql-1.4.1-1.fc9 has been submitted as an update for Fedora 9
php-pear-MDB2-Driver-pgsql-1.4.1-1.fc8 has been submitted as an update for Fedora 8
php-pear-MDB2-Driver-pgsql-1.4.1-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-pear-MDB2-Driver-pgsql'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-7217
php-pear-MDB2-Driver-pgsql-1.4.1-1.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-pear-MDB2-Driver-pgsql'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-7219
php-pear-MDB2-Driver-pgsql-1.4.1-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
php-pear-MDB2-Driver-pgsql-1.4.1-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.