Bug 458610 - Review Request: php-pear-MDB2-Driver-pgsql - PostgreSQL MDB2 driver
Review Request: php-pear-MDB2-Driver-pgsql - PostgreSQL MDB2 driver
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Extras Quality Assurance
:
: 438805 (view as bug list)
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-10 17:20 EDT by Johan Cwiklinski
Modified: 2008-09-11 12:54 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-09-11 12:53:53 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Johan Cwiklinski 2008-08-10 17:20:23 EDT
Spec URL: http://odysseus.x-tnd.be/fedora/php-pear-MDB2-Driver-pgsql/php-pear-MDB2-Driver-pgsql.spec
SRPM URL: http://odysseus.x-tnd.be/fedora/php-pear-MDB2-Driver-pgsql/php-pear-MDB2-Driver-pgsql-1.4.1-1.fc9.src.rpm
Mock Log: http://odysseus.x-tnd.be/fedora/php-pear-MDB2-Driver-pgsql/php-pear-MDB2-Driver-pgsql-build.log
Description: 
This is the PostgreSQL MDB2 driver.

rpmlint against srpm complains about a patch non apllied, I think it's just because the path is applied once installed (bug #379081).

rpmlint against rpm also complains about missing documentation, there is no documentation provided upstream for this package.
Comment 1 Jason Tibbitts 2008-08-10 17:28:44 EDT
*** Bug 438805 has been marked as a duplicate of this bug. ***
Comment 2 Jason Tibbitts 2008-08-10 18:52:15 EDT
Indeed, rpmlint complains about the two things you've pointed out; I agree that both complaints can be ignored.

The only thing I could suggest you add is some statement of why the file has to be patched after installation instead if in %prep as usual.  (I understand why but it might not be obvious to whoever might glance at the spec in the future.)

* source files match upstream:
   7a051e90c63897701a93c9d3b02d79e6c696240c552694cf34cbc7eab6284691  
   MDB2_Driver_pgsql-1.4.1.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream (it's in each of the PHP files).
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   php-pear(MDB2_Driver_pgsql) = 1.4.1
   php-pear-MDB2-Driver-pgsql = 1.4.1-1.fc10
  =
   /bin/sh
   /usr/bin/pear
   php-pear(MDB2) >= 2.4.1
   php-pear(PEAR)

* %check is not present; there's a test suite, but it would require a running 
   postgres instance and pear tests aren't runnable at build time in any case.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module registration).
* code, not content.
* no documentation to worry about.

APPROVED
Comment 3 Johan Cwiklinski 2008-08-11 01:00:15 EDT
New Package CVS Request
=======================
Package Name: php-pear-MDB2-Driver-pgsql
Short Description: PostgreSQL MDB2 Driver
Owners: trasher
Branches: F-8 F-9 EL-5
InitialCC: trasher
Cvsextras Commits: yes
Comment 4 Kevin Fenzi 2008-08-11 13:33:52 EDT
cvs done.
Comment 5 Fedora Update System 2008-08-11 14:44:49 EDT
php-pear-MDB2-Driver-pgsql-1.4.1-1.fc9 has been submitted as an update for Fedora 9
Comment 6 Fedora Update System 2008-08-11 14:45:49 EDT
php-pear-MDB2-Driver-pgsql-1.4.1-1.fc8 has been submitted as an update for Fedora 8
Comment 7 Fedora Update System 2008-08-12 14:25:54 EDT
php-pear-MDB2-Driver-pgsql-1.4.1-1.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-pear-MDB2-Driver-pgsql'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-7217
Comment 8 Fedora Update System 2008-08-12 14:26:03 EDT
php-pear-MDB2-Driver-pgsql-1.4.1-1.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-pear-MDB2-Driver-pgsql'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-7219
Comment 9 Fedora Update System 2008-09-11 12:53:50 EDT
php-pear-MDB2-Driver-pgsql-1.4.1-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 10 Fedora Update System 2008-09-11 12:54:41 EDT
php-pear-MDB2-Driver-pgsql-1.4.1-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.