Red Hat Bugzilla – Bug 459173
Review Request: python-peak-util-extremes - Production-quality 'Min' and 'Max' objects
Last modified: 2016-09-19 22:38:59 EDT
Spec URL: http://lmacken.fedorapeople.org/rpms/python-peak-util-extremes.spec
SRPM URL: http://lmacken.fedorapeople.org/rpms/python-peak-util-extremes-1.1-1.fc9.src.rpm
The peak.util.extremes module provides a production-quality implementation of
the Min and Max objects from PEP 326. While PEP 326 was rejected for inclusion
in the language or standard library, the objects described in it are useful in
a variety of applications. In PEAK, they have been used to implement generic
functions (in RuleDispatch and PEAK-Rules), as well as to handle scheduling and
time operations in the Trellis. Because this has led to each project copying
the same code, we've now split the module out so it can be used independently.
The license is unclear. PSF should be Python to quiet rpmlint and you'll need to check with upstream to see what version of ZPL this is (probably 2.1 but not safe to assume).
The changelog has inconsistent numbering: 0.6-1 vs 1.1-1
Fixed license and changelog version
+ package builds in mock
+ rpmlint is silent
+ source files match upstream.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Compiler flags are honored correctly.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.
New Package CVS Request
Package Name: python-peak-util-extremes
Short Description: Production-quality 'Min' and 'Max' objects
Branches: F-8 F-9 EL-4 EL-5
This package has been imported a built.