Spec URL: http://lmacken.fedorapeople.org/rpms/python-peak-rules.spec SRPM URL: http://lmacken.fedorapeople.org/rpms/python-peak-rules-0.5a1.dev-0.2569.fc9.src.rpm Description: SymbolType gives you access to the peak.util.symbols module, previously available only by installing the full PEAK toolkit. peak.util.symbols provides a Symbol type and two built-in symbols that are used by PEAK: NOT_FOUND and NOT_GIVEN.
rpmlint complains that the license is unknown. The spec defines it as PSF or ZPL. The possiblilities for ZPL are: ZPLv1.0, ZPLv1.0+, ZPLv2.0, ZPLv2.0+, ZPLv2.1, or ZPLv2.1+ Is PSF the Python license? The %doc files all have executable permissions!? (e.g. /usr/share/doc/python-peak-rules-0.5a1.dev/Indexing.txt) The changelog version doesn't match the RPM version: 1.0-1 vs 0.5a1.dev-0.2569 The Source0 URL is incorrect. I found it at http://peak.telecommunity.com/snapshots/
(In reply to comment #1) > rpmlint complains that the license is unknown. The spec defines it as PSF or > ZPL. > > The possiblilities for ZPL are: ZPLv1.0, ZPLv1.0+, ZPLv2.0, ZPLv2.0+, ZPLv2.1, > or ZPLv2.1+ > Is PSF the Python license? I believe so, yes. I'm not quite sure about what to do with the License tag, as it says "PSF or ZPL" in the docs... > The %doc files all have executable permissions!? (e.g. > /usr/share/doc/python-peak-rules-0.5a1.dev/Indexing.txt) Fixed. > The changelog version doesn't match the RPM version: 1.0-1 vs 0.5a1.dev-0.2569 Fixed. > The Source0 URL is incorrect. I found it at > http://peak.telecommunity.com/snapshots/ Fixed. http://lmacken.fedorapeople.org/rpms/python-peak-rules.spec http://lmacken.fedorapeople.org/rpms/python-peak-rules-0.5a1.dev-0.2569.fc9.src.rpm
From what I can tell from http://www.python.org/psf/license/ PSF is Python Software Foundation so using "Python" seems the right thing for PSF. ZPL is defined at http://www.zope.org/Resources/ZPL but you'd need to ask the author which version he wants to use.
BTW, I confirmed with spot that we can't assume a ZPL version and need to ask upstream to clarify.
To quote upstream author, Phillip J. Eby: "ZPL 2.1; see http://www.zope.org/Resources/ZPL"
I updated the License tag to 'Python or ZPLv2.1' http://lmacken.fedorapeople.org/rpms/python-peak-rules.spec http://lmacken.fedorapeople.org/rpms/python-peak-rules-0.5a1.dev-0.2569.fc9.src.rpm
The license is ok now and the package builds and passes rpmlint but will not install due to missing dependencies: python-peak-util-addons >= 0.6 is needed by python-peak-rules-0.5a1.dev-0.2569.fc10.noarch python-peak-util-assembler >= 0.3 is needed by python-peak-rules-0.5a1.dev-0.2569.fc10.noarch python-peak-util-extremes >= 1.1 is needed by python-peak-rules-0.5a1.dev-0.2569.fc10.noarch These aren't found in the F10 repo either.
(In reply to comment #7) > The license is ok now and the package builds and passes rpmlint but will not > install due to missing dependencies: > > python-peak-util-addons >= 0.6 is needed by > python-peak-rules-0.5a1.dev-0.2569.fc10.noarch > python-peak-util-assembler >= 0.3 is needed by > python-peak-rules-0.5a1.dev-0.2569.fc10.noarch > python-peak-util-extremes >= 1.1 is needed by > python-peak-rules-0.5a1.dev-0.2569.fc10.noarch > > These aren't found in the F10 repo either. Yep -- all of the review requests are dependencies of this bug.
Review: + package builds in mock (development i386). + rpmlint is silent for RPM - Source0 is still incorrect + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License not included in source, not in rpm either. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears consistent. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. APPROVED if you fix the Source0 before committing the package. I built and installed the missing dependencies and was able to use tg-admin to quickstart a new project and verified that it started and served at least the root page.
New Package CVS Request ======================= Package Name: python-peak-rules Short Description: Generic functions and business rules support systems Owners: lmacken Branches: F-8 F-9 EL-4 EL-5
cvs done.
python-peak-util-assembler-0.5-1.fc8,python-peak-util-extremes-1.1-1.fc8,python-peak-util-addons-0.6-1.fc8,python-peak-rules-0.5a1.dev-0.2569.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/python-peak-util-assembler-0.5-1.fc8,python-peak-util-extremes-1.1-1.fc8,python-peak-util-addons-0.6-1.fc8,python-peak-rules-0.5a1.dev-0.2569.fc8
python-peak-util-symbols-1.0-1.fc9,python-peak-util-assembler-0.5-1.fc9,python-peak-util-extremes-1.1-1.fc9,python-peak-util-addons-0.6-1.fc9,python-peak-rules-0.5a1.dev-0.2569.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/python-peak-util-symbols-1.0-1.fc9,python-peak-util-assembler-0.5-1.fc9,python-peak-util-extremes-1.1-1.fc9,python-peak-util-addons-0.6-1.fc9,python-peak-rules-0.5a1.dev-0.2569.fc9
python-peak-util-symbols-1.0-1.fc9, python-peak-util-assembler-0.5-1.fc9, python-peak-util-extremes-1.1-1.fc9, python-peak-util-addons-0.6-1.fc9, python-peak-rules-0.5a1.dev-0.2569.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-peak-util-symbols python-peak-util-assembler python-peak-util-extremes python-peak-util-addons python-peak-rules'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-8247
python-peak-util-assembler-0.5-1.fc8, python-peak-util-extremes-1.1-1.fc8, python-peak-util-addons-0.6-1.fc8, python-peak-rules-0.5a1.dev-0.2569.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-peak-util-assembler python-peak-util-extremes python-peak-util-addons python-peak-rules'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-8369
python-peak-util-assembler-0.5-1.fc8, python-peak-util-extremes-1.1-1.fc8, python-peak-util-addons-0.6-1.fc8, python-peak-rules-0.5a1.dev-0.2569.fc8, python-peak-util-symbols-1.0-1.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-peak-util-assembler python-peak-util-extremes python-peak-util-addons python-peak-rules python-peak-util-symbols'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-8369
python-peak-util-assembler-0.5-1.fc8, python-peak-util-extremes-1.1-1.fc8, python-peak-util-addons-0.6-1.fc8, python-peak-rules-0.5a1.dev-0.2569.fc8, python-peak-util-symbols-1.0-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
python-peak-util-symbols-1.0-1.fc9, python-peak-util-assembler-0.5-1.fc9, python-peak-util-extremes-1.1-1.fc9, python-peak-util-addons-0.6-1.fc9, python-peak-rules-0.5a1.dev-0.2569.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please un-retire the epel7 branch. Package Change Request ====================== Package Name: python-peak-rules New Branches: epel7 Owners: dcallagh
Complete.