Red Hat Bugzilla – Bug 459966
Review Request: libgxim - GObject-based XIM protocol library
Last modified: 2008-08-29 03:54:06 EDT
Spec URL: http://tagoh.fedorapeople.org/libgxim/libgxim.spec SRPM URL: http://tagoh.fedorapeople.org/libgxim/libgxim-0.1.0-1.fc9.src.rpm Description: libgxim is a X Input Method protocol library that is implemented by GObject. this library helps you to implement XIM servers or client applications to communicate through XIM protocol without using Xlib API directly, particularly if your application uses GObject-based main loop.
Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=784476 + rpmlint is silent for SRPM and for RPM. + source files match upstream url e0a74b61f39a5e39d6e7f645e2f67be7 libgxim-0.1.0.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + libgxim.pc file present. + -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package libgxim-0.1.0-1.fc10 -> Provides: libgxim.so.0 Requires(interp): /sbin/ldconfig /sbin/ldconfig Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libcairo.so.2 libdbus-1.so.3 libdbus-glib-1.so.2 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libgxim.so.0 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpthread.so.0 librt.so.1 rtld(GNU_HASH) + Package libgxim-devel-0.1.0-1.fc10 -> Provides: pkgconfig(libgxim) = 0.1.0 Requires: libgxim.so.0 Suggestions:- 1) make install should be used like make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" 2) drop %doc from -devel as same you included in main package. 3) group name for main package should be Group: System Environment/Libraries 4) you can also think of adding tests directory to %doc of -devel in future APPROVED.
Thanks for reviewing. New Package CVS Request ======================= Package Name: libgxim Short Description: GObject-based XIM protocol library Owners: tagoh Branches: devel InitialCC:
cvs done.
Package has been built in koji.