Bug 461678 - Review Request: purple-microblog - Libpurple plug-in supporting microblog services like Twitter
Summary: Review Request: purple-microblog - Libpurple plug-in supporting microblog se...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dan Horák
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 470836 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-09-09 20:01 UTC by Matěj Cepl
Modified: 2018-04-11 09:37 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-09-15 08:45:52 UTC
Type: ---
Embargoed:
dan: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Matěj Cepl 2008-09-09 20:01:46 UTC
Spec URL: http://mcepl.fedorapeople.org/rpms/purple-microblogging.spec
SRPM URL: http://mcepl.fedorapeople.org/rpms/purple-microblogging-0.1.2-1.fc9.src.rpm
Description: 
The project aims is to develop a set of microblog support in LibPurple base
client like Pidgin. Currently it only support Twitter through the conversation
windows.

Currently the source can be built and run on Windows Vista and Ubuntu 8.04.1.
Other platform with LibPurple should works, but we don't have time (yet) to
test it.

Comment 1 Matěj Cepl 2008-09-11 15:06:24 UTC
New version fixing warnings and hopefully a lot of other issue (patches have been sent upstream). Rebased against the latest SVN (development is pretty fast, so it seemed like improper to patch old version).

Source RPM: http://mcepl.fedorapeople.org/rpms/purple-microblogging-0.1.2-0.20080911svn148.fc10.src.rpm
Spec file is in the same URL.

Comment 2 Matěj Cepl 2008-09-11 15:06:54 UTC
... and built in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=820399

Comment 3 Dan Horák 2008-09-12 13:36:33 UTC
formal review is here, see notes below

OK*	source files match upstream:
	    159198753234e6d9323af1dca88fae089002d164  mbpurple-0.1.2.tar.gz
BAD	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible. License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (Rawhide/x86_64).
OK	debuginfo package looks complete.
OK	rpmlint is silent.
OK	final provides and requires look sane.
N/A	%check is present and all tests pass.
OK	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	no scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	not a GUI app.

- better is to call the source archive mbpurple-svn148.tar.gz for a svn snapshot
- maybe "purple-microblog" is better name, there is stronger connection to the upstream name
- because this is a post-release snapshot, the version-release should be 0.1.2-1.20080911svn148
- you can disable paralel make as it is not supported by the makefiles (there is a note about that in the build.log)

Comment 4 Matěj Cepl 2008-09-13 06:28:00 UTC
koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=824205
Source RPM http://mcepl.fedorapeople.org/rpms/purple-microblog-0.1.2-1.20080911svn148.1.fc9.src.rpm

All comments accepted, except for the paralel building -- makefiles are such mess that it would be too much hassle to fix it.

Comment 5 Dan Horák 2008-09-13 07:15:01 UTC
All issues are fixed, so this package is APPROVED, but the release should be 2.20080911svn148 instead of 1.20080911svn148.1 (https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages)

ad parallel make - I mean just remove the %{_smp_mflags} from the make call in the %build section

Comment 6 Matěj Cepl 2008-09-13 20:18:16 UTC
New Package CVS Request
=======================
Package Name: purple-microblog
Short Description: Libpurple plug-in supporting microblog services like Twitter
Owners: mcepl
Branches: F-8 F-9
InitialCC:

Comment 7 Kevin Fenzi 2008-09-14 22:23:52 UTC
cvs done.

Comment 9 Fedora Update System 2008-09-15 09:08:54 UTC
purple-microblog-0.1.2-2.20080911svn148.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/purple-microblog-0.1.2-2.20080911svn148.fc8

Comment 10 Fedora Update System 2008-09-15 09:10:02 UTC
purple-microblog-0.1.2-2.20080911svn148.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/purple-microblog-0.1.2-2.20080911svn148.fc9

Comment 11 Fedora Update System 2008-10-23 18:34:09 UTC
purple-microblog-0.1.2-2.20081023svn165.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/purple-microblog-0.1.2-2.20081023svn165.fc9

Comment 12 Fedora Update System 2008-10-23 18:35:52 UTC
purple-microblog-0.1.2-2.20081023svn165.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/purple-microblog-0.1.2-2.20081023svn165.fc8

Comment 13 Fedora Update System 2008-11-09 09:24:55 UTC
purple-microblog-0.2.0-1.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/purple-microblog-0.2.0-1.fc9

Comment 14 Stu Tomlinson 2008-11-10 16:16:13 UTC
*** Bug 470836 has been marked as a duplicate of this bug. ***

Comment 15 Fedora Update System 2008-11-19 14:49:41 UTC
purple-microblog-0.2.0-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.