Bug 462892 - gfs: use dlm_posix_set_fsid() for compat with old gfs_controld
Summary: gfs: use dlm_posix_set_fsid() for compat with old gfs_controld
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: gfs-kmod
Version: 5.3
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: David Teigland
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On: 462354
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-09-19 14:58 UTC by David Teigland
Modified: 2010-01-12 03:29 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-01-20 21:18:28 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2009:0132 0 normal SHIPPED_LIVE gfs-kmod bug-fix update 2009-01-20 16:04:57 UTC

Description David Teigland 2008-09-19 14:58:59 UTC
Description of problem:

Bug 462354 allows gfs1&2 to work with old versions of gfs_controld.
It adds the function dlm_posix_set_fsid() which gfs1 needs to
call to set the fsid in the plock ops.

Once the patch for 462354 is included, and dlm_posix_set_fsid is
whitelisted, gfs1 can get this patch:

diff --git a/gfs-kernel/src/gfs/lock_dlm_mount.c b/gfs-kernel/src/gfs/lock_dlm_m
index 9546a13..909d6c2 100644
--- a/gfs-kernel/src/gfs/lock_dlm_mount.c
+++ b/gfs-kernel/src/gfs/lock_dlm_mount.c
@@ -154,6 +154,8 @@ static int gdlm_mount(char *table_name, char *host_data,
                goto out_kobj;
        }
 
+       dlm_posix_set_fsid(ls->dlm_lockspace, ls->id);
+
        lockstruct->ls_jid = ls->jid;
        lockstruct->ls_first = ls->first;
        lockstruct->ls_lockspace = ls;
 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Kiersten (Kerri) Anderson 2008-09-23 15:39:02 UTC
This is dependent on the gfs compatibility patch for the dlm kernel.  Once that patch is in, then this will get commited.  Added exception flag to allow us to be backward compatible with earlier rhel 5 cman packages.

Comment 5 Kiersten (Kerri) Anderson 2008-10-21 13:58:19 UTC
Turns out we can do this after beta builds.

Comment 7 Nate Straz 2008-11-13 20:12:01 UTC
Verified plocks work on a RHEL 5.3 node which has joined a RHEL 5.3 cluster
using tree RHEL5.3-Server-20081105.1.

Comment 9 errata-xmlrpc 2009-01-20 21:18:28 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-0132.html


Note You need to log in before you can comment on or make changes to this bug.