Bug 463133 - Review Request: perl-Log-Dispatch-Perl - Use core Perl functions for logging
Summary: Review Request: perl-Log-Dispatch-Perl - Use core Perl functions for logging
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 459536
TreeView+ depends on / blocked
 
Reported: 2008-09-22 07:10 UTC by Ralf Corsepius
Modified: 2010-06-21 01:51 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-09-25 00:02:52 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Ralf Corsepius 2008-09-22 07:10:54 UTC
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Log-Dispatch-Perl.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-Log-Dispatch-Perl-0.03-1.fc10.src.rpm

Description:
The "Log::Dispatch::Perl" module offers a logging alternative using
standard Perl core functions. It allows you to fall back to the common Perl
alternatives for logging, such as "warn" and "cluck". It also adds the
possibility for a logging action to halt the current environment, such as
with "die" and "croak".

This package is a dependency of rt-3.8's "devel-mode".
i.e. it's not required for ordinary run-time use of rt3, but only by people developing on rt3.

Comment 1 Parag AN(पराग) 2008-09-22 07:48:14 UTC
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=835671
- rpmlint is silent NOT for SRPM and for RPM.
perl-Log-Dispatch-Perl.noarch: W: invalid-license CHECK
perl-Log-Dispatch-Perl.src: W: invalid-license CHECK
==> You should change it to "GPL+ or Artistic"
+ source files match upstream url
e23dcef192fc33f0213e4c72553b76a7  Log-Dispatch-Perl-0.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful!
Files=1, Tests=21,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.04 cusr  0.00 csys =  0.06 CPU)
+ Package perl-Log-Dispatch-Perl-0.03-1.fc10 =>
  Provides: perl(Log::Dispatch::Perl) = 0.03
  Requires: perl(base) perl(strict)

Suggestions:-
  I see license for this package is "GPL+ or Artistic", but you listed as CHECK(GPL+ or Artistic) ?

Do you see any issues with license here?

Comment 2 Ralf Corsepius 2008-09-22 08:03:21 UTC
(In reply to comment #1)
> Do you see any issues with license here?
Nope. This was an oversight.

cpanspec had added it and I missed to adjust it.

Update:

Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Log-Dispatch-Perl.spec
SRPM URL:
http://corsepiu.fedorapeople.org/packages/perl-Log-Dispatch-Perl-0.03-2.fc10.src.rpm

Comment 3 Parag AN(पराग) 2008-09-22 08:22:02 UTC
APPROVED.

Comment 4 Ralf Corsepius 2008-09-22 08:31:25 UTC
New Package CVS Request
=======================
Package Name: perl-Log-Dispatch-Perl
Short Description: Use core Perl functions for logging
Owners: corsepiu
Branches: F-9 F-8
InitialCC: perl-sig

Comment 5 Huzaifa S. Sidhpurwala 2008-09-22 09:33:21 UTC
cvs done

Comment 6 Ralf Corsepius 2008-09-22 09:58:41 UTC
I am unable to check in/cvs-import to any of the repositories you've created.

*** Access denied: corsepiu is not in ACL for rpms/perl-Log-Dispatch-Perl/devel
cvs commit: Pre-commit check failed
**** Access denied: corsepiu is not in ACL for rpms/perl-Log-Dispatch-Perl/F-8
cvs commit: Pre-commit check failed
**** Access denied: corsepiu is not in ACL for rpms/perl-Log-Dispatch-Perl/F-9
cvs commit: Pre-commit check failed
cvs [commit aborted]: correct above errors first!

Comment 7 Huzaifa S. Sidhpurwala 2008-09-22 10:09:55 UTC
hmm really strange, can you try this once more please.
Most of the packages with perl-sig in the cc list are ok,
I wondering what went wrong with this.

Comment 8 Ralf Corsepius 2008-09-22 10:28:12 UTC
(In reply to comment #7)
> hmm really strange, can you try this once more please.
More strange was the fact that adding the *.gz to the lookaside cache had worked, while the "cvs commit" failed :/

> I wondering what went wrong with this.
No idea :-)

Now, "cvs commit" below perl-Log-Dispatch-Perl worked. 
I will try to cvs-import the other packages soon.

Comment 9 Ralf Corsepius 2008-09-22 10:55:21 UTC
The crazyness continues:

Now bodhi's web GUI doesn't offer the F-9/F-8 packages which just completed.


Commandline "make bodhi" bombs out with this error:
...
Traceback (most recent call last):
  File "/usr/bin/bodhi", line 5, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python2.5/site-packages/pkg_resources.py", line 2561, in <module>
    working_set.require(__requires__)
  File "/usr/lib/python2.5/site-packages/pkg_resources.py", line 626, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python2.5/site-packages/pkg_resources.py", line 524, in resolve
    raise DistributionNotFound(req)  # XXX put more info here
pkg_resources.DistributionNotFound: bodhi==0.5.0

Comment 10 Fedora Update System 2008-09-22 12:10:11 UTC
perl-Log-Dispatch-Perl-0.03-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/perl-Log-Dispatch-Perl-0.03-2.fc9

Comment 11 Fedora Update System 2008-09-22 12:12:02 UTC
perl-Log-Dispatch-Perl-0.03-2.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/perl-Log-Dispatch-Perl-0.03-2.fc8

Comment 12 Fedora Update System 2008-09-25 00:02:48 UTC
perl-Log-Dispatch-Perl-0.03-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2008-09-25 00:18:57 UTC
perl-Log-Dispatch-Perl-0.03-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Mark Chappell 2010-06-18 16:47:16 UTC
corsepiu is listed as not interested in EPEL


Package Change Request
======================
Package Name: perl-Log-Dispatch-Perl
New Branches: EL-6
Owners: tremble

Comment 15 Kevin Fenzi 2010-06-21 01:51:45 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.