Spec URL: http://bkearney.fedorapeople.org/ace-console-wui.spec SRPM URL: http://bkearney.fedorapeople.org/ace-console-wui-0.0.3-2.fc9.src.rpm Description: Apache module for the Appliance Configuration Engine (see https://bugzilla.redhat.com/show_bug.cgi?id=463226)
Updated the packages per the review of the ace pakacge Spec URL: http://bkearney.fedorapeople.org/ace-console-wui.spec SRPM URL: http://bkearney.fedorapeople.org/ace-console-wui-0.0.3-3.fc9.src.rpm rpmlint clean koji build clean
OK - Package name OK - License info is accurate OK - License tag is correct and licenses are approved OK - License files are installed as %doc OK - Specfile name OK - Specfile is legible OK - No prebuilt binaries included OK - BuildRoot value (one of the recommended values) OK - PreReq not used OK - Source md5sum matches upstream FIX - No hardcoded pathnames mentions /etc/pam.d, use %_sysconfdir OK - Package owns all the files it installs OK - 'Requires' create needed unowned directories OK - Package builds successfully on i386 and x86_64 (mock) OK - BuildRequires sufficient OK - File permissions set properly OK - Macro usage is consistent FIX - rpmlint is silent NIT - lots of tabs lead to goofy indentation; remove tabs I get the following from rpmlint: ace-console-wui.noarch: E: zero-length /usr/share/ace/ace-console-wui/db/development.sqlite3 ace-console-wui.noarch: W: symlink-should-be-relative /usr/share/ace/ace-console-wui/config/environments/production.rb /etc/ace-console-wui/production.rb ace-console-wui.noarch: W: symlink-should-be-relative /usr/share/ace/ace-console-wui/config/environments/test.rb /etc/ace-console-wui/test.rb ace-console-wui.noarch: W: symlink-should-be-relative /usr/share/ace/ace-console-wui/config/database.yml /etc/ace-console-wui/database.yml ace-console-wui.noarch: W: symlink-should-be-relative /usr/share/ace/ace-console-wui/config/environments/development.rb /etc/ace-console-wui/development.rb ace-console-wui.noarch: W: dangling-symlink /usr/share/ace/ace-console-wui/tmp /var/lib/%{inst_name}/tmp ace-console-wui.noarch: W: symlink-should-be-relative /usr/share/ace/ace-console-wui/tmp /var/lib/%{inst_name}/tmp ace-console-wui.noarch: E: incoherent-subsys /etc/rc.d/init.d/ace-console-wui ace-console-wui} Either fix them or explain why they are ok to keep.
I have uploaded a new srpm. Information is below. Spec URL: http://bkearney.fedorapeople.org/ace-console-wui.spec SRPM URL: http://bkearney.fedorapeople.org/ace-console-wui-0.0.3-4.fc9.src.rpm Clean Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=884303 Explanations on the rpmlint errors: ace-console-wui.noarch: E: zero-length /usr/share/ace/ace-console-wui/db/development.sqlite3 ----------------------------------------------------- Currently rails requires a database. This is the empty sqlite backed file for this. ace-console-wui.noarch: W: symlink-should-be-relative (several of these) ------------------------------------------------------------------------ The symlinks are to macro driven locations (e.g. linking to %{_sysconfdir}/%{name}/test.rb). This seems a less fragile approach then using lots of nested ../ ace-console-wui.noarch: E: incoherent-subsys /etc/rc.d/init.d/ace-console-wui ------------------------------------------------------------------------------ This service is using mongrel-rails under the cover. The lockfile is parameter driven (stole this from ovirt) and that trigger this error.
This ticket is terribly old. I'm not planning to review this package, but I can make some comments. Still builds OK. rpmlint says: ace-console-wui.noarch: W: dangling-symlink /usr/share/ace/ace-console-wui/tmp /var/lib/%{inst_name}/tmp You didn't address this above. There's only one occurrence of "%{inst_name}" in the spec; it's not defined anywhere, so it's just used verbatim. This is almost certainly some sort of oversight. Your %description should be at least one complete sentence. It seems to be missing punctuation currently. Your macro usage is inconsistent. If for whatever reason you really want to type a lot and use "%{__mv}" and the like, you need to use "%{__rm} as well.
PING It's been almost ten months with no progress; This bug should be closed soon if there is no response, shouldn't it?
Bryan, As you have already closed this bug, I'm just blocking it to FE-DEADREVIEW, accordingly to Fedora's Policy for stalled package reviews: http://fedoraproject.org/wiki/Policy_for_stalled_package_reviews Regards