Red Hat Bugzilla – Bug 463436
Review Request: purple-facebookchat - libpurple plug-in supporting facebook IM
Last modified: 2018-04-11 05:02:32 EDT
Spec URL: http://mcepl.fedorapeople.org/rpms/pidgin-facebookchat.spec
SRPM URL: http://mcepl.fedorapeople.org/rpms/pidgin-facebookchat-1.35-2.fc10.src.rpm
This is a Facebook chat plugin for Pidgin and libpurple
messengers. It connects to the new Facebook Chat IM service
without the need for an API key.
Currently the plugin can log into the Facebook servers, grab the
buddy list, send/receive messages, add/remove friends, receive
notifications, search for Facebook friends and set your Facebook
Some changes made according to assignees comments on IRC.
Spec URL: http://mcepl.fedorapeople.org/rpms/purple-facebookchat.spec
koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=839209
formal review is here, see the notes below:
OK source files match upstream:
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
BAD compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.
- you are not passing the CFLAGS="$RPM_OPT_FLAGS" as a parameter to make
- you should remove the source archive creation from the "all" target in your makefile
- I would not compress the updated makefile
with the reviewr's changes
All issues are fixed, so this package is APPROVED
New Package CVS Request
Package Name: purple-facebookchat
Short Description: libpurple plug-in supporting facebook IM
Branches: F-8 F-9