Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-sc.spec SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-sc-0.20040601-1.fc9.src.rpm Description: Sardinian hunspell dictionary
SPEC is missing ">" in iconv command koji build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=910282
That was a bit silly: New SPEC: http://people.redhat.com/caolanm/hunspell/hunspell-sc.spec New SRPM: http://people.redhat.com/caolanm/hunspell/hunspell-sc-0.20040601-2.fc9.src.rpm
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=914108 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 05284890c3445c5850a3c1410790a057 aspell5-sc-1.0.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED.
New Package CVS Request ======================= Package Name: hunspell-sc Short Description: Sardinian hunspell dictionary Owners: caolanm Branches: InitialCC:
cvs done.