Bug 469743 (perl-IO-TieCombine) - Review Request: perl-IO-TieCombine - Produce tied (and other) separate but combined variables
Summary: Review Request: perl-IO-TieCombine - Produce tied (and other) separate but co...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: perl-IO-TieCombine
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/IO-TieCom...
Whiteboard:
Depends On:
Blocks: perl-App-Cmd
TreeView+ depends on / blocked
 
Reported: 2008-11-03 20:26 UTC by Chris Weyl
Modified: 2008-11-06 04:23 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-11-06 04:23:56 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2008-11-03 20:26:39 UTC
Spec URL: http://fedorapeople.org/~cweyl/review/perl-IO-TieCombine.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-IO-TieCombine-1.000-1.fc9.src.rpm

Description:
This package allows you to tie separate variables into a combined whole, using
ties and other magic.  This can be very useful when, say, you want a unified
output from various different things that return data in different ways
(STDIN/ERR, scalars, handles, etc).


Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=916535

Comment 1 Parag AN(पराग) 2008-11-04 10:39:28 UTC
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=916894
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
a2e0d8019cf8ca3ea33d970d93f9853e  IO-TieCombine-1.000.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave 
All tests successful.
Files=1, Tests=5,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.04 cusr  0.01 csys =  0.07 CPU)
+ Package  perl-IO-TieCombine-1.000-1.fc10 =>
Provides: perl(IO::TieCombine) = 1.000 perl(IO::TieCombine::Handle) = 1.000 perl(IO::TieCombine::Scalar) = 1.000
Requires: perl(Carp) perl(IO::TieCombine::Handle) perl(IO::TieCombine::Scalar) perl(Symbol) perl(strict) perl(warnings)

APPROVED.

Comment 2 Chris Weyl 2008-11-04 16:29:13 UTC
New Package CVS Request
=======================
Package Name: perl-IO-TieCombine
Short Description: produce tied (and other) separate but combined variables
Owners: cweyl
Branches: F-8 F-9 devel
InitialCC: perl-sig

Comment 3 Chris Weyl 2008-11-04 22:03:58 UTC
New Package CVS Request
=======================
Package Name: perl-IO-TieCombine
Short Description: produce tied (and other) separate but combined variables
Owners: cweyl
Branches: F-8 F-9 F-10 devel
InitialCC: perl-sig

Comment 4 Kevin Fenzi 2008-11-05 22:46:10 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.