Spec URL: http://fedorapeople.org/~cweyl/review/perl-App-Cmd.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-App-Cmd-0.202-1.fc9.src.rpm Description: App::Cmd is intended to make it easy to write complex command-line applications without having to think about most of the annoying things usually involved. For information on how to start using App::Cmd, see App::Cmd::Tutorial.
Gah, this still doesn't build on rawhide becaise IO::TieCombine isn't there. And it doesn't build on F9 either; the tests fail from lack of Test::More. I went ahead and added the Test::More build dep and built on F9. The inclusion of the test suite makes the doc directory larger than the rest of the package, but the package is small so I don't see that it makes much difference in the end. I'll go ahead and approve this but of course you'll need to fix the dependencies in order to build it. * source files match upstream: a3a240fb8e680417e9610790112ee80129cfec65a259f97cf77832009f3a06a4 App-Cmd-0.202.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. X BuildRequires are proper (needs Test::More) Note: added BuildRequires: perl(Test::More) to complete this review: * %clean is present. * package builds in mock (F9, x86_64) after adding build dep. * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(App::Cmd) = 0.202 perl(App::Cmd::ArgProcessor) = 0.202 perl(App::Cmd::Command) = 0.202 perl(App::Cmd::Command::commands) = 0.202 perl(App::Cmd::Command::help) = 0.202 perl(App::Cmd::Plugin) perl(App::Cmd::Setup) perl(App::Cmd::Simple) = 0.202 perl(App::Cmd::Subdispatch) = 0.202 perl(App::Cmd::Subdispatch::DashedStyle) = 0.202 perl(App::Cmd::Tester) perl(App::Cmd::Tester::Result) perl-App-Cmd = 0.202-1.fc9 = perl >= 0:5.006 perl(:MODULE_COMPAT_5.10.0) perl(App::Cmd) perl(App::Cmd::ArgProcessor) perl(App::Cmd::Command) perl(App::Cmd::Plugin) perl(App::Cmd::Subdispatch) perl(Carp) perl(Data::OptList) perl(File::Basename) perl(Module::Pluggable::Object) perl(Sub::Exporter) perl(Sub::Exporter::Util) perl(Sub::Install) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=6, Tests=42, 1 wallclock secs ( 0.34 cusr + 0.04 csys = 0.38 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is larger than the library, but still small so no subpackage is needed. * %docs are not necessary for the proper functioning of the package. APPROVED
New Package CVS Request ======================= Package Name: perl-App-Cmd Short Description: write command line apps with less suffering Owners: cweyl Branches: F-8 F-9 F-10 devel InitialCC: perl-sig
cvs done.