Bug 472348 - Review Request: hunspell-no - Norwegian hunspell dictionaaries
Summary: Review Request: hunspell-no - Norwegian hunspell dictionaaries
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 472342 (view as bug list)
Depends On:
Blocks: 479599
TreeView+ depends on / blocked
 
Reported: 2008-11-20 11:00 UTC by Caolan McNamara
Modified: 2009-01-13 21:20 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-11-25 22:56:08 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Caolan McNamara 2008-11-20 11:00:07 UTC
Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-no.spec
SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-no-2.0.10-1.fc10.src.rpm
Description: Norwegian hunspell dictionaaries

This combined Norwegian dictionary package is intended to replace the current out-of-date hunspell-nn and hunspell-nb packages

Comment 1 Parag AN(पराग) 2008-11-24 05:14:13 UTC
Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=947321
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
dab12f79c6ccc9b92b23733bb29fc234  no_NO-pack2-2.0.10.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.

Comment 2 Caolan McNamara 2008-11-24 09:18:12 UTC
New Package CVS Request
=======================
Package Name: hunspell-no
Short Description: Norwegian hunspell dictionaries
Owners: caolanm
Branches: devel
InitialCC:

Comment 3 Dennis Gilmore 2008-11-25 16:43:42 UTC
CVS Done

Comment 4 Caolan McNamara 2008-11-25 17:11:21 UTC
*** Bug 472342 has been marked as a duplicate of this bug. ***

Comment 5 Caolan McNamara 2008-11-25 22:56:08 UTC
Built into rawhide (i.e. F11)

Comment 6 Caolan McNamara 2009-01-12 09:18:28 UTC
Package Change Request
======================
Package Name: hunspell-no
New Branches: F-10
Owners: caolanm

Comment 7 Kevin Fenzi 2009-01-13 21:20:37 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.