Bug 473318 - Review Request: system-config-nfs-docs - Documentation for configuring an NFS server
Summary: Review Request: system-config-nfs-docs - Documentation for configuring an NFS...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-11-27 17:14 UTC by Nils Philippsen
Modified: 2009-01-14 13:26 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-01-14 13:26:40 UTC
Type: ---
Embargoed:
j: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Nils Philippsen 2008-11-27 17:14:08 UTC
Spec URL: http://nphilipp.fedorapeople.org/review/system-config-nfs-docs.spec
SRPM URL: http://nphilipp.fedorapeople.org/review/system-config-nfs-docs-1.0.1-1.fc10.src.rpm
Description: This package contains the online documentation for system-config-nfs which is a graphical user interface for creating, modifying, and deleting nfs shares.

Comment 1 Nils Philippsen 2008-12-08 18:37:42 UTC
NB: The package can only be installed with the related tool (with the same documentation stripped) which I plan to release together with this package (once the review is finished).

I've uploaded new files with some fixes at:
Spec: http://nphilipp.fedorapeople.org/review/system-config-nfs-docs.spec
SRPM: http://nphilipp.fedorapeople.org/review/system-config-nfs-docs-1.0.2-1.fc10.src.rpm

Comment 3 Nils Philippsen 2008-12-18 12:25:53 UTC
New files with fixed rarian-compat dependencies at:

Spec: http://nphilipp.fedorapeople.org/review/system-config-nfs-docs.spec
SRPM: http://nphilipp.fedorapeople.org/review/system-config-nfs-docs-1.0.4-1.fc10.src.rpm

Comment 4 Jason Tibbitts 2008-12-19 17:50:27 UTC
This is essentially identical to the other system-config-*-docs packages, so I'll be brief.  rpmlint:
  system-config-nfs-docs.noarch: W: obsolete-not-provided system-config-nfs
not a problem.

* source files match upstream.  sha256sum:
  29ad78d3a42ba2f0590a482054ac7a337f09dff5b0a408d9e56ab3db37df7447  
   system-config-nfs-docs-1.0.4.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* rpmlint has acceptable complaints.
* final provides and requires are sane.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* scriptlets are OK.
* acceptable content

APPROVED

Comment 5 Nils Philippsen 2008-12-19 22:37:36 UTC
Thanks for reviewing!

New Package CVS Request
=======================
Package Name: system-config-nfs-docs
Short Description: Documentation for configuring an NFS server
Owners: nphilipp
Branches: F-9 F-10

Comment 6 Kevin Fenzi 2008-12-21 04:37:02 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.