Bug 473413 - Review Request: system-config-samba-docs - Documentation for configuring a Samba server
Review Request: system-config-samba-docs - Documentation for configuring a Sa...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2008-11-28 07:08 EST by Nils Philippsen
Modified: 2009-01-14 08:26 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2009-01-14 08:26:58 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
kevin: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Nils Philippsen 2008-11-28 07:08:58 EST
Spec URL: http://nphilipp.fedorapeople.org/review/system-config-samba-docs.spec
SRPM URL: http://nphilipp.fedorapeople.org/review/system-config-samba-docs-1.0.1-1.fc10.src.rpm
Description: This package contains the online documentation for system-config-samba which is a graphical user interface for creating, modifying, and deleting samba shares.
Comment 1 Nils Philippsen 2008-12-08 13:38:08 EST
NB: The package can only be installed with the related tool (with the same documentation stripped) which I plan to release together with this package (once the review is finished).

I've uploaded new files with some fixes at:
Spec: http://nphilipp.fedorapeople.org/review/system-config-samba-docs.spec
SRPM: http://nphilipp.fedorapeople.org/review/system-config-samba-docs-1.0.2-1.fc10.src.rpm
Comment 4 Jason Tibbitts 2008-12-19 13:39:34 EST
This is essentially identical to the other system-config-*-docs packages, so I'll be brief.  rpmlint:
  system-config-samba-docs.noarch: W: obsolete-not-provided system-config-samba
not a problem.

* source files match upstream.  sha256sum:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* rpmlint has acceptable complaints.
* final provides and requires are sane.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* scriptlets are OK.
* acceptable content


All done!
Comment 5 Nils Philippsen 2008-12-19 17:36:04 EST
Thanks for reviewing!

New Package CVS Request
Package Name: system-config-samba-docs
Short Description: Documentation for configuring a Samba server
Owners: nphilipp
Branches: F-9 F-10
Comment 6 Kevin Fenzi 2008-12-20 23:39:56 EST
cvs done.

Note You need to log in before you can comment on or make changes to this bug.