Red Hat Bugzilla – Bug 473718
Review Request: perl-Directory-Scratch-Structured - Creates temporary files and directories from a structured description
Last modified: 2012-01-27 07:58:42 EST
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Directory-Scratch-Structured.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Directory-Scratch-Structured-0.03-1.fc9.src.rpm Description: This module adds a _create_structured_tree_ subroutine to Directory::Scratch. This method is useful to create a directory structure needed for temporary purposes, e.g. for testing.
Directory::Scratch does not seem to be available in rawhide yet.
Working on it -- apparently going from F-9 to F-10 broke my posting script in so-far mysterious ways.
Result: FAIL Failed 1/10 test programs. 1/32 subtests failed. koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=998817
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Directory-Scratch-Structured.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Directory-Scratch-Structured-0.04-1.fc10.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1026687
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1026687 + rpmlint is silent for SRPM and for RPM. + source files match upstream url ef6155cc8a9723e0e9614508aa1c592d Directory-Scratch-Structured-0.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=4, Tests=18, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.50 cusr 0.04 csys = 0.56 CPU) + Package perl-Directory-Scratch-Structured-0.04-1.fc11 => Provides: perl(Directory::Scratch::Structured) = 0.04 Requires: perl(Carp) perl(Directory::Scratch) perl(English) perl(Readonly) perl(Sub::Exporter) perl(Sub::Install) perl(strict) perl(vars) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-Directory-Scratch-Structured Short Description: Creates temporary files and directories from a structured description Owners: cweyl Branches: F-9 F-10 devel InitialCC:
cvs done. BTW, your cvs requests for perl packages recently don't seem to have perl-sig as a CC. Is that an oversight? If you want me to go back and add that to a list of packages, just email me the request.
(In reply to comment #7) > BTW, your cvs requests for perl packages recently don't seem to have perl-sig > as a CC. Is that an oversight? If you want me to go back and add that to a list > of packages, just email me the request. Ugh, thanks for pointing that out. Seems like my script slipped a bit there; I'll go poke around and generate a list.
Thanks for the review! :-)
Package Change Request ====================== Package Name: perl-Directory-Scratch-Structured New Branches: Owners: InitialCC: perl-sig Please add perl-sig user with watch* permissions only to all Fedora branches.
Done.