Spec URL: http://fedorapeople.org/~cweyl/review/perl-Directory-Scratch.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Directory-Scratch-0.14-2.fc9.src.rpm Description: When writing test suites for modules that operate on files, it's often inconvenient to correctly create a platform-independent temporary storage space, manipulate files inside it, then clean it up when the test exits. The inconvenience usually results in tests that don’t work everwhere, or worse, no tests at all. This module aims to eliminate that problem by making it easy to do things right.
Koji (dist-f11): http://koji.fedoraproject.org/koji/taskinfo?taskID=994338
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=994338 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 3e759c3a5ff8c678725aad99e80a5c14 Directory-Scratch-0.14.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=37, Tests=268, 6 wallclock secs ( 0.20 usr 0.07 sys + 4.96 cusr 0.49 csys = 5.72 CPU) + Package perl-Directory-Scratch-0.14-2.fc11 => Provides: perl(Directory::Scratch) = 0.14 Requires: perl(Carp) perl(File::Copy) perl(File::Slurp) perl(File::Spec) perl(File::Temp) perl(File::stat) perl(Path::Class) perl(Scalar::Util) perl(overload) perl(strict) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-Directory-Scratch Short Description: Self-cleaning scratch space for tests Owners: cweyl Branches: F-9 F-10 devel InitialCC:
cvs done.
Package Change Request ====================== Package Name: perl-Directory-Scratch InitialCC: perl-sig Please add perl-sig to this package with watchbugzilla and watchcommits bits on all fedora branches.
Done.
Package Change Request ====================== Package Name: perl-Directory-Scratch New Branches: epel7 Owners: lkundrak The Fedora maintainer is unfortunately not maintaining EPEL packages: http://fedoraproject.org/wiki/EPEL/ContributorStatusNo
Git done (by process-git-requests).