Spec URL: http://thias.fedorapeople.org/review/mod_limitipconn/mod_limitipconn.spec SRPM URL: http://thias.fedorapeople.org/review/mod_limitipconn/mod_limitipconn-0.23-1.src.rpm Description: Apache module which allows web server administrators to limit the number of simultaneous downloads permitted from a single IP address.
formal review is here: OK source files match upstream: 8a7d2d991328fa67fffa617942436049799bfa02 mod_limitipconn-0.23.tar.bz2 OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible. License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app.
Thanks a lot for the review, Dan! New Package CVS Request ======================= Package Name: mod_limitipconn Short Description: Simultaneous connection limiting module for Apache Owners: matthias Branches: F-9 F-10 EL-5 InitialCC:
please use FAS name in the Owners field, not email address. cvs done. ;)
I've submitted the F9 and F10 builds to be pushed at last, closing. Thanks Dan and Kevin!