Bug 474444 - Zero-length pid files cause resource start failures
Summary: Zero-length pid files cause resource start failures
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: rgmanager
Version: 5.3
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Marek Grac
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks: 480828
TreeView+ depends on / blocked
 
Reported: 2008-12-03 21:12 UTC by Lon Hohberger
Modified: 2009-09-02 11:05 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 480828 (view as bug list)
Environment:
Last Closed: 2009-09-02 11:05:22 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Preliminary patch (650 bytes, patch)
2008-12-03 21:12 UTC, Lon Hohberger
no flags Details | Diff
Final patch (657 bytes, patch)
2009-01-20 19:27 UTC, Marek Grac
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2009:1339 0 normal SHIPPED_LIVE Low: rgmanager security, bug fix, and enhancement update 2009-09-01 10:42:29 UTC

Description Lon Hohberger 2008-12-03 21:12:49 UTC
Created attachment 325599 [details]
Preliminary patch

config-utils.sh has check_pid_file() which is a little too zealous in its checks.

For example, if a PID file exists but is of zero length, a start for a service might fail.

This patch unlinks a zero-length PID file, since it's not useful data.  I don't know whether or not it's correct to do this generally.

This issue was first reported in bug 462910 .

Comment 1 Marek Grac 2009-01-20 19:27:04 UTC
Created attachment 329501 [details]
Final patch

Patch follows the idea of preliminary patch. Test & remove were moved to better section as there is a bug in proposed patch (-z will test for length of string; not length of filename).

Comment 4 errata-xmlrpc 2009-09-02 11:05:22 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-1339.html


Note You need to log in before you can comment on or make changes to this bug.