Red Hat Bugzilla – Bug 476599
Review Request: python-transaction - Transaction Management for Python
Last modified: 2013-01-09 23:58:40 EST
Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/python-transaction.spec
SRPM URL: http://konradm.fedorapeople.org/fedora/SRPMS/python-transaction-1.0-0.1.a1.fc9.src.rpm
This package contains a generic transaction implementation for Python.
It is mainly used by the ZODB, though.
This doesn't build in rawhide currently:
DEBUG: This script requires setuptools version 0.6c7 to run (even to display
DEBUG: help). I will attempt to download it for you (from
DEBUG: http://pypi.python.org/packages/2.6/s/setuptools/), but
DEBUG: you may need to enable firewall access for this script first.
DEBUG: I will start the download in 15 seconds.
DEBUG: (Note: if this machine does not have network access, please obtain the file
DEBUG: and place it in this directory before rerunning this script.)
It then tries to download the .egg file which really isn't going to work in the builders.
tests/test_savepoint.py is under ZPL 2.0 instead of 2.1 like the rest of the files. Might be an oversight by the upstream, should contact them, or otherwise make note in the spec. I'm not sure what the differences are between 2.0 and 2.1 and what happens when you combine both in a work.
the %doc call should include LICENSE.txt since it is shipped with upstream. http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
Otherwise, looks good. Just a few things to fix there.
I take that back about building.
It builds if you add python-setuptools to your BuildRequires.
rpmlint is clean.
Oh, oops. I think python-setuptools should be part of the spec template (/etc/rpmdevtools/spectemplate-python.spec) since it's used for all distutils/setuputils python scripts in Fedora. It would certainly help me remember it.
I'm pretty sure tests/test_savepoint.py is supposed to be ZPLv2.1 like everything else, but I will fire off an email to upstream.
python-setuptools isn't needed for distutils. Distutils is part of the python package itself: $ rpm -qf /usr/lib64/python2.5/distutils/core.pyc
Might be worth porting stuff still using setuputils over to distutils. http://docs.python.org/distutils/index.html#distutils-index
It seems to actually be in the documentation at python.org unlike setuptools/setuputils
Everything looks good now, approving.
Thanks for the review!
New Package CVS Request
Package Name: python-transaction
Short Description: Transaction Management for Python
Branches: F-10 F-9
Except not. This package is already in fedora. Owned by lmacken.
See bug 468222
Yeah, oops. Closing.
*** This bug has been marked as a duplicate of bug 468222 ***