Bug 477208 - GFS2: Parsing of remount arguments incorrect
Summary: GFS2: Parsing of remount arguments incorrect
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: GFS-kernel
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Steve Whitehouse
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 479401
TreeView+ depends on / blocked
 
Reported: 2008-12-19 17:03 UTC by Steve Whitehouse
Modified: 2009-03-27 10:40 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 479401 (view as bug list)
Environment:
Last Closed: 2009-03-27 10:40:46 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
Initial patch, not tested so far. (9.70 KB, patch)
2008-12-22 13:27 UTC, Steve Whitehouse 		no flags Details | Diff
View All

Description Steve Whitehouse 2008-12-19 17:03:09 UTC 
There are some issues relating to the remount command which need to be fixed. Firstly, if an invalid argument is found, the remount process returns an error, but any valid arguments seen before the invalid one will have already been processed.

Secondly, the spectator flag seems not to be handled correctly.

This bug is just so that I don't forget to take a proper look at this.
Comment 1 Steve Whitehouse 2008-12-22 13:27:12 UTC 
Created attachment 327640 [details]
Initial patch, not tested so far.

A first go at this. I'll probably hold off sending this for a little while as I know it will conflict with other items in the queue.
Comment 2 Steve Whitehouse 2009-01-06 14:26:27 UTC 
Tested & posted to the -nmw git tree.
Comment 3 Steve Whitehouse 2009-03-27 10:40:46 UTC 
In 2.6.30
Note You need to log in before you can comment on or make changes to this bug.