Bug 479401
| Summary: | GFS2: Parsing of remount arguments incorrect | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Steve Whitehouse <swhiteho> | ||||||||
| Component: | kernel | Assignee: | Robert Peterson <rpeterso> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Cluster QE <mspqa-list> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | low | ||||||||||
| Version: | 5.4 | CC: | adas, bmarzins, dzickus, edamato, lwang, rpeterso | ||||||||
| Target Milestone: | rc | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | 477208 | Environment: | |||||||||
| Last Closed: | 2009-09-02 09:01:54 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | 477208 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Steve Whitehouse
2009-01-09 12:02:30 UTC
Created attachment 328969 [details]
RHEL 5.4 version of the remount patch
Created attachment 332640 [details]
Better patch
The previous patch referenced function match_strlcpy which only
exists in the upstream kernels. This patch ports the simple
function inline. This has been tested on system roth-01 with the
2.6.18-131 kernel plus this patch. I did a bunch of mounts and
remounts using a variety of mount options. Everything seems to
work properly.
Patch sent to rhkernel-list for inclusion into 5.4. Changing status to POST and adding Don and Linda to the cc-list. Created attachment 332740 [details]
Revised RHEL5 patch
This one puts match_strlcpy where it belongs, in lib/parser.c.
Unfortunately, I needed to add #include <linux/types.h> to
include/linux/parser.h in order for the kernel to compile properly
because the callers may not know what a size_t is. This statement
does not appear in the upstream kernel.
in kernel-2.6.18-133.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 Please do NOT transition this bugzilla state to VERIFIED until our QE team has sent specific instructions indicating when to do so. However feel free to provide a comment indicating that this fix has been verified. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2009-1243.html |