Red Hat Bugzilla – Bug 479401
GFS2: Parsing of remount arguments incorrect
Last modified: 2009-09-02 05:01:54 EDT
Already fixed in upstream.
+++ This bug was initially created as a clone of Bug #477208 +++
There are some issues relating to the remount command which need to be fixed. Firstly, if an invalid argument is found, the remount process returns an error, but any valid arguments seen before the invalid one will have already been processed.
Secondly, the spectator flag seems not to be handled correctly.
This bug is just so that I don't forget to take a proper look at this.
--- Additional comment from email@example.com on 2008-12-22 08:27:12 EDT ---
Created an attachment (id=327640)
Initial patch, not tested so far.
A first go at this. I'll probably hold off sending this for a little while as I know it will conflict with other items in the queue.
--- Additional comment from firstname.lastname@example.org on 2009-01-06 09:26:27 EDT ---
Tested & posted to the -nmw git tree.
Created attachment 328969 [details]
RHEL 5.4 version of the remount patch
Created attachment 332640 [details]
The previous patch referenced function match_strlcpy which only
exists in the upstream kernels. This patch ports the simple
function inline. This has been tested on system roth-01 with the
2.6.18-131 kernel plus this patch. I did a bunch of mounts and
remounts using a variety of mount options. Everything seems to
Patch sent to rhkernel-list for inclusion into 5.4. Changing status
to POST and adding Don and Linda to the cc-list.
Created attachment 332740 [details]
Revised RHEL5 patch
This one puts match_strlcpy where it belongs, in lib/parser.c.
Unfortunately, I needed to add #include <linux/types.h> to
include/linux/parser.h in order for the kernel to compile properly
because the callers may not know what a size_t is. This statement
does not appear in the upstream kernel.
You can download this test kernel from http://people.redhat.com/dzickus/el5
Please do NOT transition this bugzilla state to VERIFIED until our QE team
has sent specific instructions indicating when to do so. However feel free
to provide a comment indicating that this fix has been verified.
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.