Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-instant.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-instant-0.9.5-1.fc10.src.rpm Project URL: http://www.fenics.org/wiki/Instant Description: Instant is a Python module that allows for instant inlining of C and C++ code in Python. It is a small Python module built on top of SWIG and Distutils. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1097698 rpmlint output: [fab@laptop24 noarch]$ rpmlint python-instant-0.9.5-1.fc10.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [fab@laptop24 SRPMS]$ rpmlint python-instant-0.9.5-1.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Review: + package builds in mock. koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1098608 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 279884a0ad84ac4b1de3fc54fccf5984 instant-0.9.5.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + defattr usage is correct. + %doc files not present. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI App. Suggestions: 1) you can consider adding tests to %doc. This will make rpmlint unhappy to make it happy APPROVED.
ah I missed to type that make it happy by using following in %prep chmod 644 tests/*
Good point, thanks. I will add the test stuff before cvs import.
New Package CVS Request ======================= Package Name: python-instant Short Description: Python module for instant inlining of C and C++ code Owners: fab Branches: F-9 F-10 InitialCC:
cvs done.
python-instant-0.9.5-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update python-instant'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1384
python-instant-0.9.5-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-instant'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1386
Was pushed to stable https://admin.fedoraproject.org/updates/F9/FEDORA-2009-1384 https://admin.fedoraproject.org/updates/F10/FEDORA-2009-1386
Package Change Request ====================== Package Name: python-instant New Branches: el6 Owners: jgu InitialCC:
Git done (by process-git-requests).