Spec URL: http://people.fedoraproject.org/~hadess/gstreamer-rtsp/gstreamer-rtsp.spec SRPM URL: http://people.fedoraproject.org/~hadess/gstreamer-rtsp/gstreamer-rtsp-0.10.1.0-1.fc10.src.rpm Description: A GStreamer-based RTSP server library, with Python and Vala bindings. Required to package gnome-dvb-daemon
Failed to build on F-11, x86_64 http://koji.fedoraproject.org/koji/taskinfo?taskID=1316484
Python requires missing it seems.
Fixed in: http://people.fedoraproject.org/~hadess/gstreamer-rtsp/gstreamer-rtsp-0.10.1.0-2.fc10.src.rpm http://people.fedoraproject.org/~hadess/gstreamer-rtsp/gstreamer-rtsp.spec Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1316764
REVIEW: - rpmlint is not silent: [petro@host-12-116 Desktop]$ rpmlint gstreamer-rtsp-* gstreamer-rtsp.i586: E: library-without-ldconfig-postin /usr/lib/libgstrtspserver-0.10.so.0.0.0 gstreamer-rtsp.i586: E: library-without-ldconfig-postun /usr/lib/libgstrtspserver-0.10.so.0.0.0 gstreamer-rtsp-devel.i586: W: no-documentation gstreamer-rtsp-python.i586: W: no-documentation gstreamer-rtsp-vala.i586: W: no-documentation 5 packages and 0 specfiles checked; 2 errors, 3 warnings. [petro@host-12-116 Desktop]$ Regarding the first messages - please, add %post -p /sbin/ldconfig %postun -p /sbin/ldconfig Other messages may be ignored. + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines . + The License field in the package spec file must matches the actual license. + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package matches the upstream source: [petro@Sulaco SOURCES]$ md5sum gst-rtsp-0.10.1.0.tar.bz2* 67133d588a5153d80a4f8828aad2ec83 gst-rtsp-0.10.1.0.tar.bz2 67133d588a5153d80a4f8828aad2ec83 gst-rtsp-0.10.1.0.tar.bz2.1 [petro@Sulaco SOURCES]$ + The package successfully compiles and builds into binary rpms on at least one primary architecture (see koji log above). + All build dependencies are listed in BuildRequires. - Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. See rpmlint messages above. - A package must own all directories that it creates. Unfortunately, %{_datadir}/gst-rtsp in devel-subpackage is not owned. Please, add it as %dir. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissable content. + No large documentation files. + Everything, the package includes as %doc, does not affect the runtime of the application. + Header files are in a -devel package. + No static libraries. - The devel sub-package (containing pkgconfig(.pc) file) MUST have 'Requires: pkgconfig' (for directory ownership and usability). + The library files that ends in .so (without suffix) are in a -devel package. + The devel sub-package requires the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} + The package does NOT contain any .la libtool archives. + Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages must be valid UTF-8. - Missing "Requires:" * gstreamer-devel for devel sub-package (%{_includedir}/gstreamer-0.10/gst/) * pkgconfig for devel (see note above, %{_libdir}/pkgconfig/) * gstreamer-python for python syb-package (%{_libdir}/python*/site-packages/gst-0.10/gst) * vala for vala sub-package (%{_datadir}/vala/vapi/)
Fixed in: http://people.fedoraproject.org/~hadess/gstreamer-rtsp/gstreamer-rtsp-0.10.1.0-3.fc10.src.rpm http://people.fedoraproject.org/~hadess/gstreamer-rtsp/gstreamer-rtsp.spec Let me know if I missed anything.
I don't see any other issues here, so this package is APPROVED.
New Package CVS Request ======================= Package Name: gstreamer-rtsp Short Description: GStreamer RTSP server library Owners: hadess Branches: F-11 InitialCC:
cvs done.
Thanks for the review, Peter. Built in F11 and devel.