Red Hat Bugzilla – Bug 484217
[PATCH] only call fedora-setup-keyboard for keyboards
Last modified: 2009-03-13 00:41:06 EDT
Created attachment 330987 [details]
Patch against the fdi file we ship in X
Currently we run fedora-setup-keyboard for every device that has keys (capability input.keys) which results into useless calls for devices that has only one button (Power Button, Sleep Button, etc)
Changing the keyboard layout for such devices is useless, because they don't respect any layout anyway.
The attached patch fixes this by checking for the capability input.keyboard.
1; Well we are checking if input.xkb.layout exists but hal adds this for every device that has the capability input.keys in /usr/share/hal/fdi/policy/10osvendor/10-keymap.fdi
With this patch everything should work as expected with the small benefit that we only call fedora-setup-keyboard once for most system (unless multiple keyboards are detected) which should speed up the boot process.
Applied in xorg-x11-server-18.104.22.1682-3. Thanks for the patch.
xorg-x11-server-1.5.3-13.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Apparently, this fix causes more troubles than it solves, see:
Fix in F-10 has been reverted because of bug 484488 which we couldn't narrow down.
The same fix is in rawhide though where the conflicts between hal, x, gdm and gnome are resolved differently and 484488 hopefully does not have any effect.