Spec URL: http://wwoods.fedorapeople.org/review/debuginfofs.spec SRPM URL: http://wwoods.fedorapeople.org/review/debuginfofs-0.1-0.fc10.src.rpm Description: debuginfofs is a network-mountable filesystem that provides the debugging symbols needed to generate a fully annotated backtrace.
This is the unofficial review - Could not locate the upstream Source0 (debuginfofs-0.1.tar.bz2) to compare the checksum. (The snapshot from GIT summary is a tar.gz file, while the included package has tar.bz2) - rpmlint outputs the following: rpmlint -iv /root/rpmbuild/RPMS/noarch/debuginfofs-server-0.1-0.fc10.noarch.rpm debuginfofs-server.noarch: I: checking debuginfofs-server.noarch: W: conffile-without-noreplace-flag /etc/httpd/conf.d/dav-debuginfo.conf A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here - Package does not include license text. SUGGESTIONS: - In "%sfiles server", use "%{_sbindir}/debuginfofs-mirror" instead of "/usr/sbin/debuginfofs-mirror". - In "/etc/rc.d/init.d/debuginfofs": * The chkconfig header has the startPriority + stopPriority > 100. * The script does not have all the required actions. (Missing reload, force-reload, usage) Please see http://fedoraproject.org/wiki/Packaging/SysVInitScript. OKAYS: - rpmlint is quiet for debuginfofs package - package built, and installed cleanly - BuildRoot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - file permission (-,root,root,-) - rpm -qp --provides ~/rpmbuild/RPMS/noarch/debuginfofs-0.1-0.fc10.noarch.rpm config(debuginfofs) = 0.1-0.fc10 debuginfofs = 0.1-0.fc10 - rpm -qp --provides ~/rpmbuild/RPMS/noarch/debuginfofs-server-0.1-0.fc10.noarch.rpm config(debuginfofs-server) = 0.1-0.fc10 debuginfofs-server = 0.1-0.fc10 - rpm -qp --requires ~/rpmbuild/RPMS/noarch/debuginfofs-0.1-0.fc10.noarch.rpm /bin/bash /bin/sh /bin/sh /bin/sh chkconfig chkconfig config(debuginfofs) = 0.1-0.fc10 initscripts initscripts rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 wdfs - rpm -qp --requires ~/rpmbuild/RPMS/noarch/debuginfofs-server-0.1-0.fc10.noarch.rpm /usr/bin/python config(debuginfofs-server) = 0.1-0.fc10 cpio httpd rpm rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Cont'd Comment#1 - Should contains "BuildRequires: python"
Thanks for the review. New version of this package coming soon. The changes have been fairly significant, and the new version will depend on davfs2, which is being reviewed in bug 488858, so it might be a couple more days.
Spec URL: http://wwoods.fedorapeople.org/review/debuginfofs.spec SRPM URL: http://wwoods.fedorapeople.org/review/debuginfofs-0.2-1.fc10.src.rpm New version of the package. For the record, the source tarball is also available here: http://wwoods.fedorapeople.org/files/debuginfofs-0.2.tar.bz2
Suravee, are you willing to continue your review? You started very good, and, I think, you should continue reviewing it.
(In reply to comment #5) > Suravee, are you willing to continue your review? You started very good, and, I > think, you should continue reviewing it. It seems not... I know to less about init scripts, but what's this rpmlint error about? debuginfofs-server.noarch: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/debuginfofs-server debuginfofs.noarch: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/debuginfofs The conf file in /usr/share should be somewhere in /etc: debuginfofs-server.noarch: W: non-etc-or-var-file-marked-as-conffile /usr/share/debuginfofs/dav-debuginfo.conf - Please use macros instead of e.g. /usr/share etc e.g. see https://fedoraproject.org/wiki/Packaging:RPMMacros - Please use 'install -p' where possible to preserve timestamps.
Is anything happening here?